Stop spelling skills extra roots in TUI requests#21492
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultforSkillsListParamsso callers can rely on the existingNonedefault for extra roots.skills/listcall sites to stop explicitly spellingper_cwd_extra_user_roots: None.PluginListParamstest initializer fix needed for protocol tests on currentmain.Why
This lets the client-side cleanup land before the server/API removal. The TUI still sends the same effective request today, but the call sites no longer explicitly depend on the extra-roots field.
Validation
just fmtcargo test -p codex-app-server-protocol skills_list_params_serialization_uses_force_reloadcargo check -p codex-tuijust fix -p codex-app-server-protocoljust fix -p codex-tuiwas run once, but clippy rewrote the TUI struct update back to the explicitNone; the intended TUI cleanup was reapplied and validated withcargo check -p codex-tui.