Skip to content

Stop spelling skills extra roots in TUI requests#21492

Draft
xli-oai wants to merge 1 commit intomainfrom
xli-codex/skills-list-tui-no-extra-roots
Draft

Stop spelling skills extra roots in TUI requests#21492
xli-oai wants to merge 1 commit intomainfrom
xli-codex/skills-list-tui-no-extra-roots

Conversation

@xli-oai
Copy link
Copy Markdown
Contributor

@xli-oai xli-oai commented May 7, 2026

Summary

  • Add Default for SkillsListParams so callers can rely on the existing None default for extra roots.
  • Update the TUI skills/list call sites to stop explicitly spelling per_cwd_extra_user_roots: None.
  • Include the one-line PluginListParams test initializer fix needed for protocol tests on current main.

Why

This lets the client-side cleanup land before the server/API removal. The TUI still sends the same effective request today, but the call sites no longer explicitly depend on the extra-roots field.

Validation

  • just fmt
  • cargo test -p codex-app-server-protocol skills_list_params_serialization_uses_force_reload
  • cargo check -p codex-tui
  • just fix -p codex-app-server-protocol
  • just fix -p codex-tui was run once, but clippy rewrote the TUI struct update back to the explicit None; the intended TUI cleanup was reapplied and validated with cargo check -p codex-tui.

@xli-oai xli-oai added the oai PRs contributed by OpenAI employees label May 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oai PRs contributed by OpenAI employees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant