Skip to content

test: deflake realtime sideband close#21506

Open
dylan-hurd-oai wants to merge 1 commit intomainfrom
codex/nightly-realtime-sideband-close-flake
Open

test: deflake realtime sideband close#21506
dylan-hurd-oai wants to merge 1 commit intomainfrom
codex/nightly-realtime-sideband-close-flake

Conversation

@dylan-hurd-oai
Copy link
Copy Markdown
Collaborator

Summary

  • Keep the mocked WebRTC sideband accept delayed beyond the negative-event observation window.
  • Removes the scheduler race where slow CI could complete the mock handshake before close aborts the sideband task.

Verification

  • just fmt
  • cargo test -p codex-core --test all suite::realtime_conversation::conversation_webrtc_close_while_sideband_connecting_drops_pending_join -- --exact (3 consecutive runs)

@dylan-hurd-oai dylan-hurd-oai added the codex Label used by connector to tag PRs that have been reviewed by Codex label May 7, 2026
@dylan-hurd-oai dylan-hurd-oai marked this pull request as ready for review May 7, 2026 07:24
@dylan-hurd-oai dylan-hurd-oai requested a review from a team as a code owner May 7, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Label used by connector to tag PRs that have been reviewed by Codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant