Skip to content

feat(ui): split review queue by item type - #55

Merged
francescobianco merged 1 commit into
openapi:mainfrom
Aaqibhafeezkhan:fix/review-queue-separation
Nov 16, 2026
Merged

francescobianco merged 1 commit into
openapi:mainfrom
Aaqibhafeezkhan:fix/review-queue-separation

Conversation

@Aaqibhafeezkhan

Copy link
Copy Markdown
Contributor

Summary

  • Split open review items into Questions to explore and Needs review.
  • Add Ask and Dismiss actions for open questions; Ask opens the Assistant with the item's research prompt.
  • Keep Resolve for review tasks.
  • Show the selected item's details, research prompts, and associated source information in the detail pane.
  • Add a core test for distinguishing question items from review tasks.

Closes #17

@Aaqibhafeezkhan Aaqibhafeezkhan left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queue now separates research questions from review tasks, preserves the existing resolve workflow, and routes questions to the Assistant without silently dismissing them.

@Aaqibhafeezkhan

Copy link
Copy Markdown
Contributor Author

Hi @francescobianco Please review/merge

@francescobianco
francescobianco merged commit b67a92a into openapi:main Nov 16, 2026
4 checks passed
@francescobianco

Copy link
Copy Markdown
Member

@Aaqibhafeezkhan thank you, and sorry it sat for a while! 🙏 This is exactly what #17 asked for.

What I especially like:

  • ReviewItem.is_question keeps the split in the core model, so it's testable without GTK, and you added the test.
  • Ask fills the Assistant with the item's own research prompt and jumps there, and Dismiss keeps questions from piling up next to real review tasks.
  • The detail pane now shows the research prompts and the source (file, status, summary), and degrades gracefully when the source is gone.

CI was green on every job, so it's merged. One small note for a future touch, not blocking: Adw.ActionRow subtitles are parsed as markup, so item.detail would need GLib.markup_escape_text like the title (that predates your PR).

This is your third merged contribution after #30 and #31, and you're already in the Openapi® contributors registry. Thank you, and the doors are wide open for whatever you'd like to take on next! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split the Review queue into "Questions to explore" and "Needs review"

2 participants