You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Sadia-Tasnim-Meem thank you for this translation! 🙏 It reads well, and the commands, links and badges are all intact. A few small fixes before we merge, all in the HTML around the text:
Language bar separator (all 7 READMEs): the new link is preceded by a plain period . instead of the middle dot · used between the other languages. It should be:
(there is also a trailing space after </p> on that line in each file.)
Language bar in README.bn.md: it was copied from the French file, so Français is bold and বাংলা is a link. Swap them: <a href="README.fr.md">Français</a> and <b>বাংলা</b>.
Demo image alt text in README.bn.md: it's still in French (gknowledge en action : …). A Bengali version of "gknowledge in action: import AI papers, get a linked wiki, ask questions with citations" would be perfect.
Tiny one, if I read it right: in gknowledge কেন, নোম অ্যাপ হিসেবে probably wants GNOME অ্যাপ হিসেবে like the rest of the file.
Once these are in I'll merge right away. Thanks again, this opens gknowledge to a lot of new readers! 🚀
@francescobianco thanks for your feedback! I made the fixes as per the instructions:
Updated the bar separator and removed the trailing space in each file
Added the link for Français and made বাংলা bold README.bn.md
Updated the demo img alt text in README.bn.md
Replaced নোম with GNOME
Hope this is working now. Glad to be a part of the project 😊
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
README.bn.mdREADME.mdCloses #39