Repository navigation
Enforce rustfmt, pedantic clippy and rustdoc in CI - #15
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
francescobianco
approved these changes
Nov 16, 2026
francescobianco
left a comment
Member
There was a problem hiding this comment.
Approved, thank you! See my comment below for the merge order.
Member
|
@LucaCappelletti94 thank you, this is a big step up for the crate! 🙏 fmt, pedantic clippy and rustdoc with warnings denied, plus the Now that #14 is merged, this one needs a quick rebase on
With those two, Since |
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this time, CI only builds and tests.
This PR adds:
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo docwith warnings denied[lints]table enablingclippy::pedanticandmissing_docsand others.# Errorsand# Panicsdoc sections. The one#[expect]needs Rust 1.81, which Refresh Cargo.lock within a declared 1.85 MSRV #14 declares.Client::newnow takes&strinstead ofString, since it never consumed the token. That breaks callers, so the next release should be 0.2, and we will actually enforce this when in a later PR I will add the semver job.