Skip to content

fix(runtime): bound complete SkillSpector requests before submission - #136

Merged
Patrick-Erichsen merged 8 commits into
mainfrom
bound-skillspector-request-budgets
Nov 2, 2026
Merged

Patrick-Erichsen merged 8 commits into
mainfrom
bound-skillspector-request-budgets

Conversation

@Patrick-Erichsen

Copy link
Copy Markdown
Collaborator

Large bundled files can exceed SkillSpector’s model input budget and stop scanning before independent judgment. Carry the request-budget repair from NVIDIA/SkillSpector#980 onto our pinned integration, including packet schemas and metadata prompts.

Count the complete prompt, numbered code, relevant findings and selected response schema. Use an already-loaded codec or a conservative UTF-8 byte bound without downloading a vocabulary. Packet placement reserves schema and framing overhead, so a nearly full packet splits instead of discarding all packing. Unfit requests retain their inputs and fail before a provider call. Finding ownership, security checks, retries, deadlines and honest partial reporting remain intact.

The regression tests exercise both sync and async calls through plain pytest, with plugin autoload disabled. Native production qualification now targets the exact repaired runtime and locked 77/26 dependency sets.

Validation:

  • 186 relevant integration tests pass with the production pytest flags. Paired controls reproduce four unsupported async test cases and semantic/meta packet overflow before the repair.
  • Fresh application to the pinned upstream source reconstructs every modified and added file; source binding, six qualifier unit tests, focused Go contract tests and Python lint/format pass.
  • Full Go tests and vet passed the earlier snapshot; Go source and module files have not changed since then. The current qualifier’s focused Go tests also pass.
  • The local JavaScript type-budget suite retains one failure, reproduced identically on the preceding snapshot with the same dependencies and flags. Fresh native AMD64 qualification with production Python and SDKs remains required; earlier qualification is not reused.

The exact DebugBundle 1.18.1 planner preserves all six files and 77,584 bundle lines under the unchanged 787,500 input budget. This model-free proof does not establish a completed scan or package acceptance. Both original-version scans, production adoption, publication and anonymous installation proof remain outstanding.

@Patrick-Erichsen
Patrick-Erichsen requested a review from a team as a code owner November 2, 2026 19:23
@clawsweeper

clawsweeper Bot commented Nov 2, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@Patrick-Erichsen
Patrick-Erichsen merged commit 72ce30b into main Nov 2, 2026
13 checks passed
@Patrick-Erichsen
Patrick-Erichsen deleted the bound-skillspector-request-budgets branch November 2, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant