Repository navigation
Emscripten: upgrade to version 7 - #637
Merged
Merged
Conversation
And do it the way we do it for CI and CD workflows!
There was a problem hiding this comment.
🟡 Changes recommended
An active nit remains in cmake/packages.cmake at line 441 because the newly added note contains the duplicated word “may may.”
1 open issue
What changed in this PR
Updates the WebAssembly toolchain to Emscripten 7 and refreshes the corresponding third-party dependency artifacts.
Changes:
- Updates the project version to
1.20261110.0. - Refreshes Emscripten package hashes for bundled third-party libraries.
- Adds forced inclusion of
<cstdlib>and<new>for third-party C++ builds. - Replaces the Homebrew Emscripten installation with
setup-emsdk. - Requires pinning the exact Emscripten version in all relevant setup steps and fixing the duplicated
may maywording.
| File | Summary |
|---|---|
VERSION.txt |
Updates the project version. |
src/3rdparty/zlib/CMakeLists.txt |
Refreshes the Emscripten zlib package hash. |
src/3rdparty/zipper/CMakeLists.txt |
Refreshes the Emscripten zipper package hash. |
src/3rdparty/SUNDIALS/CMakeLists.txt |
Refreshes the Emscripten SUNDIALS package hash. |
src/3rdparty/LLVM/CMakeLists.txt |
Refreshes the Emscripten LLVM package hash. |
src/3rdparty/libxml2/CMakeLists.txt |
Refreshes the Emscripten libxml2 package hash. |
src/3rdparty/libSEDML/CMakeLists.txt |
Refreshes the Emscripten libSEDML package hash. |
src/3rdparty/libSBML/CMakeLists.txt |
Refreshes the Emscripten libSBML package hash. |
src/3rdparty/libNuML/CMakeLists.txt |
Refreshes the Emscripten libNuML package hash. |
src/3rdparty/libCOMBINE/CMakeLists.txt |
Refreshes the Emscripten libCOMBINE package hash. |
src/3rdparty/libCellML/CMakeLists.txt |
Refreshes the Emscripten libCellML package hash. |
cmake/packages.cmake |
Adds Emscripten-specific forced C++ header inclusions. |
.github/workflows/buildThirdPartyLibrary.yml |
Switches WebAssembly builds to the Emscripten SDK setup action. |
This pull request requires changes.
Review effort: Lite
…hird-party libraries with Emscripten.
This is as a result of upgrading to Emscripten 7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #636.