chore: use hosted GitHub runners#61
Conversation
📝 WalkthroughWalkthroughThe release workflow for OCM components updates the CI runner for the ChangesRelease Workflow Runner Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release-ocm-components.yml (1)
10-10: Consider operational implications of switching to hosted runners.Migrating from self-hosted (
arc-scale-set) to GitHub-hosted runners has several operational implications:
- Cost: GitHub-hosted runners are billed per-minute. Monitor usage to ensure this aligns with budget expectations, especially with the matrix strategy building 7 components per release.
- Performance: Hosted runners provide consistent, clean environments but may have different performance characteristics than your self-hosted setup.
- Network access: If
arc-scale-sethad access to internal resources or private registries, ensure hosted runners can reach all required endpoints (ghcr.io access appears to be the only requirement here).- Concurrency: GitHub-hosted runner concurrency limits may differ from your self-hosted setup.
Since this relates to an internal decision (issue
#28), these factors have likely been considered, but it's worth validating in your specific context.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release-ocm-components.yml at line 10, The workflow change replaces the self-hosted runner identifier (runs-on: arc-scale-set) with GitHub-hosted runners (runs-on: ubuntu-24.04); verify and document operational implications: confirm cost impact for per-minute billing given your matrix strategy that builds 7 components, validate network access from hosted runners to required endpoints (e.g., ghcr.io) and any internal resources previously reachable by arc-scale-set, check concurrency limits and performance differences versus arc-scale-set, and either restore self-hosted use or add mitigations (monitoring/alerts, concurrency/job throttling, or documentation updates) in the release workflow configuration and project docs to reflect the decision.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/release-ocm-components.yml:
- Line 10: The workflow change replaces the self-hosted runner identifier
(runs-on: arc-scale-set) with GitHub-hosted runners (runs-on: ubuntu-24.04);
verify and document operational implications: confirm cost impact for per-minute
billing given your matrix strategy that builds 7 components, validate network
access from hosted runners to required endpoints (e.g., ghcr.io) and any
internal resources previously reachable by arc-scale-set, check concurrency
limits and performance differences versus arc-scale-set, and either restore
self-hosted use or add mitigations (monitoring/alerts, concurrency/job
throttling, or documentation updates) in the release workflow configuration and
project docs to reflect the decision.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f208e5e7-f71f-4556-8170-f59894247bb4
📒 Files selected for processing (1)
.github/workflows/release-ocm-components.yml
What
Relates to https://github.com/opendefensecloud/odd-internal/issues/28.
Testing
n/a
Checklist
Tests added/updatedn/aSummary by CodeRabbit