Skip to content

chore: use hosted GitHub runners#61

Open
yocaba wants to merge 1 commit into
mainfrom
chore/use-hosted-github-runners
Open

chore: use hosted GitHub runners#61
yocaba wants to merge 1 commit into
mainfrom
chore/use-hosted-github-runners

Conversation

@yocaba
Copy link
Copy Markdown
Contributor

@yocaba yocaba commented May 12, 2026

What

Relates to https://github.com/opendefensecloud/odd-internal/issues/28.

Testing

n/a

Checklist

  • Tests added/updated n/a
  • No breaking changes (or upgrade path documented above)
  • Readable commit history (squashed and cleaned up as desired)
  • AI code review considered and comments resolved

Summary by CodeRabbit

  • Chores
    • Updated the build infrastructure configuration for OCM component releases to improve build process reliability and compatibility.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

📝 Walkthrough

Walkthrough

The release workflow for OCM components updates the CI runner for the build-and-push job from a custom arc-scale-set runner to the standard ubuntu-24.04 Ubuntu runner.

Changes

Release Workflow Runner Update

Layer / File(s) Summary
Workflow runner configuration update
.github/workflows/release-ocm-components.yml
The build-and-push job's runs-on setting is updated to use ubuntu-24.04 instead of arc-scale-set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A runner switches from arc to cloud,
ubuntu-24.04 stands proud!
One line hops swift in the workflow track,
Building and pushing without looking back. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete and does not follow the required template structure. Missing critical sections including 'Why', detailed 'Testing' explanation, and 'Notes for reviewers'. The 'What' section only provides an issue reference without a summary. Add a one-sentence summary under 'What', explain the motivation/problem being solved under 'Why', provide details about testing methodology under 'Testing', and add any relevant notes for reviewers under 'Notes for reviewers'.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: use hosted GitHub runners' directly and specifically describes the main change—switching from arc-scale-set to ubuntu-24.04 runners.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/use-hosted-github-runners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yocaba
Copy link
Copy Markdown
Contributor Author

yocaba commented May 12, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/release-ocm-components.yml (1)

10-10: Consider operational implications of switching to hosted runners.

Migrating from self-hosted (arc-scale-set) to GitHub-hosted runners has several operational implications:

  • Cost: GitHub-hosted runners are billed per-minute. Monitor usage to ensure this aligns with budget expectations, especially with the matrix strategy building 7 components per release.
  • Performance: Hosted runners provide consistent, clean environments but may have different performance characteristics than your self-hosted setup.
  • Network access: If arc-scale-set had access to internal resources or private registries, ensure hosted runners can reach all required endpoints (ghcr.io access appears to be the only requirement here).
  • Concurrency: GitHub-hosted runner concurrency limits may differ from your self-hosted setup.

Since this relates to an internal decision (issue #28), these factors have likely been considered, but it's worth validating in your specific context.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release-ocm-components.yml at line 10, The workflow change
replaces the self-hosted runner identifier (runs-on: arc-scale-set) with
GitHub-hosted runners (runs-on: ubuntu-24.04); verify and document operational
implications: confirm cost impact for per-minute billing given your matrix
strategy that builds 7 components, validate network access from hosted runners
to required endpoints (e.g., ghcr.io) and any internal resources previously
reachable by arc-scale-set, check concurrency limits and performance differences
versus arc-scale-set, and either restore self-hosted use or add mitigations
(monitoring/alerts, concurrency/job throttling, or documentation updates) in the
release workflow configuration and project docs to reflect the decision.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/release-ocm-components.yml:
- Line 10: The workflow change replaces the self-hosted runner identifier
(runs-on: arc-scale-set) with GitHub-hosted runners (runs-on: ubuntu-24.04);
verify and document operational implications: confirm cost impact for per-minute
billing given your matrix strategy that builds 7 components, validate network
access from hosted runners to required endpoints (e.g., ghcr.io) and any
internal resources previously reachable by arc-scale-set, check concurrency
limits and performance differences versus arc-scale-set, and either restore
self-hosted use or add mitigations (monitoring/alerts, concurrency/job
throttling, or documentation updates) in the release workflow configuration and
project docs to reflect the decision.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f208e5e7-f71f-4556-8170-f59894247bb4

📥 Commits

Reviewing files that changed from the base of the PR and between b6a7363 and 97dc74c.

📒 Files selected for processing (1)
  • .github/workflows/release-ocm-components.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants