feat: support npm workspaces for local development#185
Merged
arbrandes merged 1 commit intoopenedx:mainfrom Apr 2, 2026
Merged
feat: support npm workspaces for local development#185arbrandes merged 1 commit intoopenedx:mainfrom
arbrandes merged 1 commit intoopenedx:mainfrom
Conversation
arbrandes
force-pushed
the
workspaces-dev
branch
2 times, most recently
from
7af2983 to
7fd4dc4
Compare
arbrandes
commented
Mar 12, 2026
arbrandes
force-pushed
the
workspaces-dev
branch
3 times, most recently
from
99b6a94 to
b13dabc
Compare
arbrandes
force-pushed
the
workspaces-dev
branch
4 times, most recently
from
dc52c84 to
d6076ab
Compare
arbrandes
force-pushed
the
workspaces-dev
branch
4 times, most recently
from
7bf03c4 to
9a339b9
Compare
Decouple clean from build in the Makefile so that watch mode can rebuild without wiping dist/. Add nodemon.json and watch:build, watch:docs, watch:pack scripts to standardize file watching. Also, ensure bin entry points are executable after build, and add bin-linking workaround to migration guide. Part of openedx#184 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
arbrandes
force-pushed
the
workspaces-dev
branch
from
9a339b9 to
ca2ceaa
Compare
Contributor
|
I see this isn't touching |
Contributor
Author
This is intentional. I see no reason to mess with the pack -> install -> build workflow in CI, which is test-site's primary purpose. (I have no idea if workspaces work for a parent directory, and it's not really important to find out, methinks.) |
brian-smith-tcril
approved these changes
Apr 2, 2026
holaontiveros
approved these changes
Apr 2, 2026
|
🎉 This PR is included in version 1.0.0-alpha.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds npm workspace support to frontend-base and documents how frontend apps should set up workspaces for local development.
The
buildMakefile target no longer depends onclean, allowing incremental rebuilds — particularly in workspace mode, where a watcher triggersbuildon every change. It also sets the executable bit on allbinentry points after compilation, sincetscdoesn't preserve it and npm doesn't bin-link workspace packages during install.The
pack:watchanddocs:watchscripts are renamed towatch:packandwatch:docsfor consistency with thewatch:buildconvention that turbo uses, andnodemon.pack.jsonis consolidated intonodemon.json.The migration guide gains a full "Set up npm workspaces" section covering turbo config, nodemon, Makefile targets with a bin-linking workaround, and bind-mount usage instructions.
LLM usage notice
Built with assistance from Claude models (mostly Opus 4.6).