Repository navigation
chore(deps): consolidate Dependabot updates for openenv-core - #1605
cursor[bot] wants to merge 0 commit into
Conversation
845ed6a to
5b2da64
Compare
There was a problem hiding this comment.
Alignment Review Report
Scope reviewed: git diff 5b2da641...845ed6a9 — this consolidated/aggregate Dependabot PR touches only .github/workflows/*.yml (5 reusable-workflow/action SHA bumps) and tests/validation_runtime/uv.lock (no pyproject.toml change in this repo). No src/, envs/, or docs changes.
Automated Checks
- Lint: N/A for this diff's actual content (0
.py/.mdfiles changed;ruff/usortcan't touch.yml/.lock). Ranbash .claude/hooks/lint.shanyway after installinguv— it exit-1's on ~2 pre-existingusortfiles (tests/envs/test_grid_world.py,test_julia_env.py, already called out as known baseline noise inAGENTS.md) and ~47 pre-existing README/docstring reformat candidates. None of those paths are in this PR's diff. - Debug code: CLEAN —
bash .claude/hooks/check-debug.shonly reports pre-existing prints/TODOs insrc/openenv/core/containers/test_local_docker_provider.py,harness/rollout.py, andruntime/uv_provider.py, none of which this PR touches. - Stale-branch/merge-conflict check: clean.
git fetch origin mainconfirmsorigin/main== this PR's base commit exactly;git merge-tree origin/main <head>returns a single clean tree (no conflict). - GitHub Actions SHA pins: verified authentic.
docker/login-action->8aa5831f...andastral-sh/setup-uv->68559e99...both match their claimed tags (v4.8.0,v10.3.3) exactly viagh api repos/<owner>/<repo>/commits/<tag>. All 5 bumps stay on full 40-char SHAs (good security hygiene, consistent with PRINCIPLES.md's reproducibility stance).
Open RFCs Context
Scanned all 11 RFCs (000–012). None cover CI/GitHub Actions, dependency management, or the tests/validation_runtime toolchain's own composition — but tests/validation_runtime/ itself is the fixture for RFC 008 (Environment Auto-Validation, In Review, @zkwentz), so a correctness regression inside its lock is read against RFC 008's reproducibility goals (see below).
Tier 1: Fixes Required
-
tests/validation_runtime/uv.lock:418—gradiois pinned to the pre-release7.0.0.dev0instead of the current latest stable release. Verified live againstpypi.org/pypi/gradio/json: stable releases6.28.0through6.31.0exist and were skipped entirely in favor of a.dev0build. -
tests/validation_runtime/uv.lock:458— same issue,gradio-clientpinned to2.8.0.dev0instead of the latest stable2.7.2.
Root cause, reproduced locally (not a guess): I copied tests/validation_runtime/ to a scratch dir, pointed its path-dependency at an absolute path, deleted uv.lock, and ran a clean-room uv lock with no flags → result: gradio==6.31.0, gradio-client==2.7.2, pillow==12.3.0 (unchanged), safehttpx==0.1.7 (unchanged), no psutil. Then I ran uv lock --upgrade-package gradio --prerelease allow on the same tree, and it reproduced every line of this PR's actual lock diff exactly: gradio→7.0.0.dev0, gradio-client→2.8.0.dev0, psutil added, safehttpx→0.2.0, and the httpx→httpx2 dependency-edge swap on gradio/gradio-client/safehttpx. So the pillow 12.3.0→13.0.0 bump at uv.lock:1088 and the new psutil entry at uv.lock:1136 are not independent legitimate bumps — they're side effects pulled in only because gradio's pre-release build requires them; the latest stable gradio does not. Whatever step regenerated this lock during the Dependabot consolidation appears to have run with --prerelease allow (or equivalent) instead of a default/stable-only resolve.
Note: httpx2 (pulled in via the gradio pre-release) is a real, legitimate package — it's the httpx-stewardship successor maintained by Pydantic/the original httpx author, not a typosquat — so that part is fine in isolation; it's only in the lock because of the pre-release jump.
Suggested fix: re-run the lock regeneration for tests/validation_runtime/uv.lock without pre-release resolution so it lands on gradio==6.31.0 / gradio-client==2.7.2 (pillow/safehttpx/psutil will then revert to their pre-PR state automatically — no separate action needed on those). uv lock --check --project tests/validation_runtime currently passes on the committed lock since it's internally consistent, it's just resolved against the wrong policy, so a plain consistency check won't catch this class of issue.
Tier 2: Alignment Discussion
Principle Conflicts
None identified. No API/reward/client-server/MCP/Pydantic surface touched.
RFC Conflicts
ALIGNMENT FLAG: Pinning a pre-release dependency inside the RFC-008 reproducible-validation fixture
- Principle/RFC at stake: RFC 008 (Environment Auto-Validation, In Review) — this fixture exists specifically to make validation runs reproducible.
- The concern: Even once fixed per Tier 1, it's worth noting why this matters here specifically:
tests/validation_runtime/is the dedicated reproducible-validation harness for RFC 008. PyPI pre-release (.devN) builds are far more likely to be withdrawn, superseded, or have their artifacts change upstream than stable pins, which is in tension with a fixture whose whole purpose is dependable, repeatable builds. This is a secondary, non-blocking note riding on the same root cause as the Tier 1 fix above, not a separate design question. - Suggested reviewer: @burtenshaw (fixture owner, authored the original
tests/validation_runtime/docker validation lab and the dependabot consolidation merges) and @zkwentz (RFC 008 author)
Summary
- 2 mechanical issues to fix (the
gradio/gradio-clientpre-release pins;pillow/psutil/safehttpxchanges resolve themselves once those two are fixed) - 1 alignment point for human review (RFC-008 reproducibility context, non-blocking)
- 0 RFC design conflicts
The GitHub Actions portion of this PR (5 SHA-pin bumps) is clean and verified authentic — no concerns there.
Sent by Cursor Automation: Pre-review


Summary
Consolidates all open Dependabot PRs that touch the core library / repo-level tooling (outside
envs/) into a single branch, rebased on latestmain. Each original dependency bump is preserved as its own commit (merged via individualdb/<PR#>branches) so history stays traceable.Included (merged cleanly, no conflicts):
/tests/validation_runtimehuggingface/doc-builderaction (build_main_documentation.yml)huggingface/doc-builderaction (upload_pr_documentation.yml)docker/login-action4.7.0 → 4.8.0huggingface/doc-builderaction (build_pr_documentation.yml)astral-sh/setup-uv10.3.0 → 10.3.3Deliberately excluded:
<4.0.0→<5.0.0. Merging this alone breaksenvs/posttrain_env/server/posttrain_environment.py(ModuleNotFoundError: No module named 'fastmcp.tools.tool'— fastmcp 4.x moved/removedToolResultfrom that import path). Verified by syncing with the new constraint (resolves fastmcp 4.1.8) and running the test suite; with the old constraint (fastmcp 3.4.11) tests pass. Since this touches a core library dependency, I left it out rather than merge a breaking change —#1331is closed with an explanation; it will need a follow-up code change before it can be safely merged.Type of Change
Alignment Checklist
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violatedRFC Status
Test Plan
uv sync --all-extrasresolves cleanly with all included dependency changes.PYTHONPATH=src:envs uv run pytest tests/ -q→ 5463 passed, 235 skipped, 5 failed. The 5 failures (test_auto_env.pyHF Space integration tests requiring network/interactive confirmation,test_websockets.pystep_count assertions) are pre-existing and reproduce identically on a cleanorigin/maincheckout — confirmed via a side-by-side baseline run. No new failures introduced.uv run ruff check src/ tests/→ all checks passed.uv run usort check src/ tests/anduv run ruff format src/ tests/ --check→ only the two pre-existing issues documented inAGENTS.md(plus one pre-existing README.md formatting note), none introduced by this change.uv lock --checkpasses fortests/validation_runtime.Claude Code Review
N/A — triage automation run; individual Dependabot PRs were reviewed for mergeability and consolidated manually, with the one breaking change (#1331) excluded and left open for a manual fix.
Note
Low Risk
Routine CI action and test-runtime dependency pins with no auth, data, or application logic changes; the one risky fastmcp bump was explicitly excluded.
Overview
Rolls multiple pending Dependabot bumps for repo-level tooling into one branch while keeping each original bump as its own commit.
Dependency / lockfile: bumps Pillow in
tests/validation_runtime(uv.lock).GitHub Actions: pins newer commits for the reusable
huggingface/doc-builderworkflows used for main, PR, and PR-upload documentation builds; bumpsastral-sh/setup-uvto v10.3.3 indiscovery-catalog.yml; and updatesdocker/login-actionindocker-build.yml.Out of scope: the fastmcp
<5.0.0constraint change is intentionally not included because it breaksposttrain_envimports against fastmcp 4.x and needs a separate code fix.Reviewed by Cursor Bugbot for commit 5b2da64. Bugbot is set up for automated code reviews on this repo. Configure here.