Repository navigation
fix(sql-optim-env): require openenv>=0.5.0 so the Docker image starts - #1622
Merged
burtenshaw merged 2 commits intoNov 13, 2026
Merged
Conversation
server/app.py passes state_cls to create_app, which the locked openenv 0.4.2 does not accept, so the Docker image exits on startup. state_cls exists from openenv 0.5.0; relock openenv only (0.4.2 -> 0.13.0).
burtenshaw
reviewed
Nov 13, 2026
burtenshaw
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, confirmed. server/app.py passes state_cls=SQLOptimState, and create_app only takes state_cls from openenv 0.5.0 on (0.4.2 does not have it), so the locked 0.4.2 cannot start the server. The lock change is limited to openenv, and the branch already includes the pillow and gradio relock from #1620.
I'll merge once the remaining check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sql_optim_env Docker image exits on startup.
server/app.pypassesstate_clstocreate_app(since 9bdd0b8), but the env'suv.lockpinsopenenv0.4.2, whosecreate_apphas no such parameter. This raises the floor toopenenv>=0.5.0, the first release withstate_cls, and relocksopenenvonly (0.4.2 -> 0.13.0). Found while testing the worker change for #1609.Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles (dependency floor and lock only, no code change).claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
envs/sql_optim_env/server/Dockerfilefrom main and ran it: the container exits withTypeError: create_app() got an unexpected keyword argument 'state_cls'. The same build from this branch reports healthy,/resetand/stepwork, and/stateand/schemareturn theSQLOptimStatefields (task_id,max_steps,episode_done, ...).create_appin openenv 0.4.2 (the last 0.4.x) has nostate_cls. Every minor release from 0.5.0 to 0.13.0 has it.openenvand its two new dependencies (jsonschema,packaging).uv sync --frozen --all-groups --all-extras --dry-run --no-install-projectpasses.PYTHONPATH=src:envsas in CI, and 164 passed on 3.12 withPYTHONPATH=envs, which uses the installed openenv 0.13.0 instead ofsrc/. CI runs these tests againstsrc/, which is why it did not catch the crash.bash .claude/hooks/lint.shandpython scripts/sync_env_docs.py --checkclean.Claude Code Review
N/A
Note
Low Risk
Dependency-only bump with no application code changes; main risk is behavior shifts from the large openenv jump (0.4.2 → 0.13.0), mitigated by tests noted in the PR.
Overview
Raises the
openenvdependency floor insql_optim_envfrom>=0.4.1to>=0.5.0and relocksopenenv0.4.2 → 0.13.0 (plus transitive addsjsonschemaandpackaging).This aligns the packaged environment with
server/app.py, which passesstate_cls=SQLOptimStatetocreate_app—a parameter missing in 0.4.x, so the Docker image was failing at startup with an unexpected keyword argument.Reviewed by Cursor Bugbot for commit a49d6a5. Bugbot is set up for automated code reviews on this repo. Configure here.