Skip to content

fix(sql-optim-env): require openenv>=0.5.0 so the Docker image starts - #1622

Merged
burtenshaw merged 2 commits into
openenv:mainfrom
OfficialAbhinavSingh:fix/sql-optim-openenv-floor
Nov 13, 2026
Merged

burtenshaw merged 2 commits into
openenv:mainfrom
OfficialAbhinavSingh:fix/sql-optim-openenv-floor

Conversation

@OfficialAbhinavSingh

@OfficialAbhinavSingh OfficialAbhinavSingh commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The sql_optim_env Docker image exits on startup. server/app.py passes state_cls to create_app (since 9bdd0b8), but the env's uv.lock pins openenv 0.4.2, whose create_app has no such parameter. This raises the floor to openenv>=0.5.0, the first release with state_cls, and relocks openenv only (0.4.2 -> 0.13.0). Found while testing the worker change for #1609.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • New environment
  • Refactoring

Alignment Checklist

Before submitting, verify:

  • I have read .claude/docs/PRINCIPLES.md and this PR aligns with our principles (dependency floor and lock only, no code change)
  • I have checked .claude/docs/INVARIANTS.md and no invariants are violated
  • I have run /pre-submit-pr (or bash .claude/hooks/lint.sh and tests) and addressed all issues

RFC Status

  • Not required (bug fix, docs, minor refactoring)
  • RFC exists: #___
  • RFC needed (will create before merge)

Test Plan

  • Built envs/sql_optim_env/server/Dockerfile from main and ran it: the container exits with TypeError: create_app() got an unexpected keyword argument 'state_cls'. The same build from this branch reports healthy, /reset and /step work, and /state and /schema return the SQLOptimState fields (task_id, max_steps, episode_done, ...).
  • create_app in openenv 0.4.2 (the last 0.4.x) has no state_cls. Every minor release from 0.5.0 to 0.13.0 has it.
  • Relocked with uv 0.13.8, so the lock diff is only openenv and its two new dependencies (jsonschema, packaging). uv sync --frozen --all-groups --all-extras --dry-run --no-install-project passes.
  • sql-optim suite: 164 passed on 3.11 and 3.12 with PYTHONPATH=src:envs as in CI, and 164 passed on 3.12 with PYTHONPATH=envs, which uses the installed openenv 0.13.0 instead of src/. CI runs these tests against src/, which is why it did not catch the crash.
  • bash .claude/hooks/lint.sh and python scripts/sync_env_docs.py --check clean.

Claude Code Review

N/A


Note

Low Risk
Dependency-only bump with no application code changes; main risk is behavior shifts from the large openenv jump (0.4.2 → 0.13.0), mitigated by tests noted in the PR.

Overview
Raises the openenv dependency floor in sql_optim_env from >=0.4.1 to >=0.5.0 and relocks openenv 0.4.2 → 0.13.0 (plus transitive adds jsonschema and packaging).

This aligns the packaged environment with server/app.py, which passes state_cls=SQLOptimState to create_app—a parameter missing in 0.4.x, so the Docker image was failing at startup with an unexpected keyword argument.

Reviewed by Cursor Bugbot for commit a49d6a5. Bugbot is set up for automated code reviews on this repo. Configure here.

server/app.py passes state_cls to create_app, which the locked openenv
0.4.2 does not accept, so the Docker image exits on startup. state_cls
exists from openenv 0.5.0; relock openenv only (0.4.2 -> 0.13.0).

@burtenshaw burtenshaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, confirmed. server/app.py passes state_cls=SQLOptimState, and create_app only takes state_cls from openenv 0.5.0 on (0.4.2 does not have it), so the locked 0.4.2 cannot start the server. The lock change is limited to openenv, and the branch already includes the pillow and gradio relock from #1620.

I'll merge once the remaining check passes.

@burtenshaw
burtenshaw merged commit 24427e4 into openenv:main Nov 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants