Repository navigation
feat(embeddings): AlphaEarth's years on the time slider (embeddings.addCube) (#1720) #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
elpidioassinaturas
wants to merge
10
commits into
opengeos:main
Choose a base branch
from
elpidioassinaturas:feat/1720-embeddings-cube
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+745
−64
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fd0a0fd
feat(embeddings): AlphaEarth's years on the time slider (embeddings.a…
elpidiofilho a3bf404
fix(embeddings): first review of addCube (#1720)
elpidiofilho 9f0338f
Merge main into feat/1720-embeddings-cube
elpidiofilho 7b4131f
fix(embeddings): say the handed-over files outside the years asked fo…
elpidiofilho 2ad3136
fix(embeddings): addCube's names, doc and place match after review (#…
elpidiofilho 8171f93
Merge main into feat/1720-embeddings-cube
elpidiofilho 8fe204e
fix(embeddings): refuse addCube's bad years and a year named twice (#…
elpidiofilho 792df07
fix(embeddings): refuse a stretch that isn't a number; say a search's…
elpidiofilho 845f1ed
Merge main into feat/1720-embeddings-cube
elpidiofilho 71825ee
docs(embeddings): addCube's doc says the app's assistant waits on the…
elpidiofilho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matching tolerance, confidence low-moderate (not verified against the index). The comment justifies
SAME_PLACE= 1e-4° by "far below a tile's 82 km", but the risk it has to cover is the other way: how much one tile's footprint can move between years. One 10 m pixel is about 9e-5° of latitude and about 1e-4° of longitude at Viçosa's latitude, so a footprint that shifts by two pixels between years would not match. That would split one tile into separate series, and the cube would show two layers with gaps instead of one. The gap would be reported as "tile-years have no file", but the cause would be misreported. The test only covers a 1e-5° offset. Suggest either a test with a 2–3 pixel shift, or a note on what the index's footprints were measured to do across years.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this against the real index. I ran
embeddings.searchfor each year from 2017 to 2025 in three areas of Brazil:[-43.5, -21.2, -42.3, -20.3][-42.3, -21.0, -41.5, -20.2][-47.5, -23.2, -46.3, -22.3]Then I grouped the rows by zone, the file's row/column suffix and the area (the name prefix changes every year), and compared the footprints.
Result: 16 tiles, 9 years each, 144 rows. Every tile's footprint is the same in all nine years, bit for bit. The largest corner spread, across all tiles and corners, is 0.0°. The index draws each year's export on the same UTM grid (8192 px tiles from a fixed origin per zone), so a tile doesn't move between years.
So 1e-4° covers float noise in the index's coordinates, which is all there is, and it is far from the 0.74° between neighbouring tiles. The comment's "far below a tile's 82 km" is about not merging neighbours. The other side, how far one tile moves between years, is 0 here. If a future export ever shifted a tile, the series would show up as two tiles with their years split, which the "N of M years" detail would make visible. No change in this PR.