Refactor form_matrix method on depletion chain class#3892
Open
eepeterson wants to merge 1 commit intoopenmc-dev:developfrom
Open
Refactor form_matrix method on depletion chain class#3892eepeterson wants to merge 1 commit intoopenmc-dev:developfrom
eepeterson wants to merge 1 commit intoopenmc-dev:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR breaks up the responsibilities of the
form_matrixmethod into separate methods - one for decay and one for the reaction rates. The decay matrix can be created once and cached on the chain so it doesn't need to be recomputed for every material for every step and/or stage in higher order integration schemes. While this provides no real performance benefit by itself yet, it enables other modifications that do and generally improves the separation of responsibility in the depletion module.Fixes # (issue)
N/A
Checklist