Skip to content

feat(web): preserve source identity in review and plan references - #915

Merged
tt-a1i merged 3 commits into
mainfrom
codex/review-source-references
Nov 7, 2026
Merged

tt-a1i merged 3 commits into
mainfrom
codex/review-source-references

Conversation

@tt-a1i

@tt-a1i tt-a1i commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Diff excerpts added to the composer lose the identity of the displayed review version. Plans can be copied in full, but selected passages cannot be referenced with their source result. Relates to #913.

Value

Feedback keeps the excerpt and its source together through the existing editable draft and ordinary user message. A renamed file's old line continues to cite its old path.

Approach

Carry repository/comparison/revision from the displayed review snapshot. Add a plan selection action carrying Session and result identity. Bound excerpts with an explicit truncation marker and invalidate plan selection when its source changes.

selected excerpt + displayed source -> editable draft -> explicit user send

References do not send, approve work, mark files viewed or create another comment store.

Validation

  • bun run check passed with Bun 1.3.14.

  • bun run test: Node 2,465 passed, 8 skipped; UI 1,637 passed.

  • Focused review/plan/composer/workbar suites: 103 passed; composer suite rerun after label simplification.

  • Native isolated loopback-provider smoke actually executed plan_ready. Ego browser interaction selected plan text and a renamed old line; the draft preserved source IDs, staged revision and original text across reload without submission or approval.

  • Independent source review found no actionable P1/P2 issue.

  • Initial CI stopped before runtime tests on Web bundle freshness. Both worktrees now have independent Bun 1.3.14 frozen installs; rebuilt assets eliminate 33 unrelated chunks. Full check/test passed again under that installation, and corrected-head CI passed.

  • Windows UI initially timed out in unchanged provider-settings-page.spec.ts (5357 ms against 5000 ms). The identical base test passed at 4736 ms; the focused local test passed unchanged. One failed-job rerun passed; the first failure is retained and no timeout was widened.

  • Final head 6e800f831effcf8d180df64fcd0a51ffbf5f47ef: CI run 42266045773 passed all 19 jobs. The repository still requires an independent GitHub approval.

  • Local combined integration of feat(web): show observed context composition in session usage #914 e156a220, feat(web): preserve source identity in review and plan references #915 6e800f83 and feat: add on-demand semantic navigation skill #916 1919dccd: full check/test passed (Node 2,471 pass / 8 existing skips; UI 1,638 pass). The two overlapping generated assets were rebuilt from combined source; no source conflicts. This is separate from individual-head CI and remote merge.

Impact

User-visible: plan passage references and versioned diff references.
Model-visible: only the source/excerpt text the user explicitly sends in an ordinary message; no new tools.
Runtime/configuration/persistence: no new owner or store; existing draft and Pi Session mechanisms remain.
Limit: review revision identifies a bounded displayed projection, not a retained full-file snapshot. Generated Web assets are included.

@tt-a1i
tt-a1i merged commit f50cd7d into main Nov 7, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant