Repository navigation
feat(web): preserve source identity in review and plan references - #915
Merged
Merged
Conversation
3 tasks done
This was referenced Nov 6, 2026
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Diff excerpts added to the composer lose the identity of the displayed review version. Plans can be copied in full, but selected passages cannot be referenced with their source result. Relates to #913.
Value
Feedback keeps the excerpt and its source together through the existing editable draft and ordinary user message. A renamed file's old line continues to cite its old path.
Approach
Carry repository/comparison/revision from the displayed review snapshot. Add a plan selection action carrying Session and result identity. Bound excerpts with an explicit truncation marker and invalidate plan selection when its source changes.
References do not send, approve work, mark files viewed or create another comment store.
Validation
bun run checkpassed with Bun 1.3.14.bun run test: Node 2,465 passed, 8 skipped; UI 1,637 passed.Focused review/plan/composer/workbar suites: 103 passed; composer suite rerun after label simplification.
Native isolated loopback-provider smoke actually executed plan_ready. Ego browser interaction selected plan text and a renamed old line; the draft preserved source IDs, staged revision and original text across reload without submission or approval.
Independent source review found no actionable P1/P2 issue.
Initial CI stopped before runtime tests on Web bundle freshness. Both worktrees now have independent Bun 1.3.14 frozen installs; rebuilt assets eliminate 33 unrelated chunks. Full check/test passed again under that installation, and corrected-head CI passed.
Windows UI initially timed out in unchanged provider-settings-page.spec.ts (5357 ms against 5000 ms). The identical base test passed at 4736 ms; the focused local test passed unchanged. One failed-job rerun passed; the first failure is retained and no timeout was widened.
Final head
6e800f831effcf8d180df64fcd0a51ffbf5f47ef: CI run 42266045773 passed all 19 jobs. The repository still requires an independent GitHub approval.Local combined integration of feat(web): show observed context composition in session usage #914
e156a220, feat(web): preserve source identity in review and plan references #9156e800f83and feat: add on-demand semantic navigation skill #9161919dccd: full check/test passed (Node 2,471 pass / 8 existing skips; UI 1,638 pass). The two overlapping generated assets were rebuilt from combined source; no source conflicts. This is separate from individual-head CI and remote merge.Impact
User-visible: plan passage references and versioned diff references.
Model-visible: only the source/excerpt text the user explicitly sends in an ordinary message; no new tools.
Runtime/configuration/persistence: no new owner or store; existing draft and Pi Session mechanisms remain.
Limit: review revision identifies a bounded displayed projection, not a retained full-file snapshot. Generated Web assets are included.