Repository navigation
qick_lib: read the reference clock of an ADC tile from the ADC parameters - #447
Merged
Merged
Conversation
…ters
The RFDC parse took C_DAC<n>_Refclk_Freq for ADC tile n too. Where ADC tile n is enabled and DAC tile n is
not, Vivado leaves the sampling rate in that DAC parameter (6400 MHz on the ZCU111), and QickSoc refuses the
firmware ("RF reference clocks [204.8, 204.8, 204.8, 6400.0] ... must all be equal"). This is the case of
the ZCU111 tProc v2 standard firmware, which uses ADC tiles 0 and 2 (the released tprocv2r21/r23 bitstreams).
Contributor
|
For reference, the buggy commit was merged in #432. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 4972d5e,
RFDC.configure()reads the reference clock of every enabled tile fromC_DAC<n>_Refclk_Freq, ADC tiles included. If ADC tile n is enabled and DAC tile n is not, Vivado leaves the sampling rate in that DAC parameter, soQickSocreads the wrong reference clock and refuses the firmware:This happens with the ZCU111 tProc v2 standard firmware, which uses ADC tiles 0 and 2. The released tprocv2r21/r23 bitstreams have the same tile layout.
The fix reads
C_ADC<n>_Refclk_Freqfor ADC tiles.Tested on a ZCU111 with the qick_lib of #446, which carries the same commit: the tProc v2 standard firmware loads and passes a loopback test.