Repository navigation
[release-6.7] Log 9591 Do not overwrite ConfigMaps owned by other resources - #3570
Conversation
Refuse to update an existing ConfigMap when its ownerReferences do not match the ClusterLogForwarder. This prevents CLO from overwriting LokiStack (or other) ConfigMaps that share the same name, and surfaces the conflict as a deployment error on the forwarder. Co-authored-by: Cursor <cursoragent@cursor.com>
Extend ownership checks beyond ConfigMaps to DaemonSet, Deployment, Service, ServiceAccount, ServiceMonitor, NetworkPolicy, Role/RoleBinding, ClusterRoleBinding, and trusted-CA ConfigMap. Shared helper matches owners by UID and surfaces a clear refuse-to-overwrite error. Co-authored-by: Cursor <cursoragent@cursor.com>
…wner arguments and UID set comparison for single-owner semantics. CLO resources have one controller owner or none (dashboard).
ClusterRoleBindings are cluster-scoped; namespaced owners (CLF) cannot own them via ownerReferences. Cleanup remains explicit via delete. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace UID-set comparison with existing HasSameOwner so ownership matching uses the same equality logic as the rest of the codebase. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
|
/label tide/merge-method-squash |
openshift-ci
Bot
added
the
tide/merge-method-squash
|
/approve |
openshift-ci
Bot
added
verified
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test functional-target |
openshift-ci
Bot
added
the
approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3e11656
into
openshift:release-6.7
This is an automated cherry-pick of #3381
/assign jcantrill