Skip to content

CONSOLE-5134: Update to Go 1.25, K8s 1.35, and Helm 3.20#16147

Open
webbnh wants to merge 4 commits intoopenshift:mainfrom
webbnh:update-go-1.25-and-helm-3.20
Open

CONSOLE-5134: Update to Go 1.25, K8s 1.35, and Helm 3.20#16147
webbnh wants to merge 4 commits intoopenshift:mainfrom
webbnh:update-go-1.25-and-helm-3.20

Conversation

@webbnh
Copy link

@webbnh webbnh commented Mar 13, 2026

OpenShift 4.22 is built on Kubernetes 1.35. This change updates Console's dependency on k8s.io/api to match that; and, it updates the dependency on helm.sh/helm/v3 to v3.20 to match that.

This requires updating the Go dependency to 1.25.

And, these three upgrades pull in updates to a dozen other direct dependencies and 30+ indirect dependencies.

So, while this change intentionally targets only the go.mod file, the go.sum file and about 2000 files in the vendor/ subdirectory are changed as well.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@webbnh
Copy link
Author

webbnh commented Mar 13, 2026

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: webbnh
Once this PR has been reviewed and has the lgtm label, please assign rhamilto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@webbnh

This comment was marked as resolved.

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to also update the go version requirement in the readme

@logonoff
Copy link
Member

/test all

@webbnh
Copy link
Author

webbnh commented Mar 18, 2026

/test all

@webbnh webbnh changed the title Update to Go 1.25 and Helm 3.20 NO-JIRA: Update to Go 1.25 and Helm 3.20 Mar 18, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2026
@openshift-ci-robot
Copy link
Contributor

@webbnh: This pull request explicitly references no jira issue.

Details

In response to this:

This change updates the dependency on helm.sh/helm/v3 to v3.20.

This requires updating the Go dependency to 1.25.

And, these two upgrades pull in updates to a dozen other direct dependencies and 30+ indirect dependencies.

So, this change targets only the go.mod file, and, of course, the go.sum file, and, of course, about 2000 files in the vendor/ subdirectory.

Please let me know if I've gone about this incorrectly. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me but I think we should have a jira for this

@webbnh webbnh changed the title NO-JIRA: Update to Go 1.25 and Helm 3.20 NO-JIRA: Update to Go 1.25, K8s 1.35, and Helm 3.20 Mar 18, 2026
@logonoff
Copy link
Member

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Mar 18, 2026
@webbnh
Copy link
Author

webbnh commented Mar 18, 2026

we should have a jira for this

OK...which "space" should I open it in (HELM, CONSOLE, something else?), and what should it say?

The Helm API should be updated when the Kubernetes API is updated, and the K8s API should presumably be updated whenever the version of it used by OpenShift is updated. (OpenShift, AIUI, is now on K8s 1.35; Console appears to have been updated to K8s 1.34 in #15926, although the description for it doesn't mention the update).

Co-authored-by: logonoff <git@logonoff.co>
@logonoff
Copy link
Member

OK...which "space" should I open it in (HELM, CONSOLE, something else?), and what should it say?

I think either is fine... it's been traditionally in OCPBUGS or CONSOLE depending on the context of the upgrade (feel free to check the git blame). You can write something along the lines of "Bump k8s and helm version", and if you want to be extra fancy about it, you could link that ticket as a "blocker" for the feature you're trying to implement with the new helm version :)

@webbnh webbnh changed the title NO-JIRA: Update to Go 1.25, K8s 1.35, and Helm 3.20 CONSOLE-5134: Update to Go 1.25, K8s 1.35, and Helm 3.20 Mar 19, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2026

@webbnh: This pull request references CONSOLE-5134 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

OpenShift 4.22 is built on Kubernetes 1.35. This change updates Console's dependency on k8s.io/api to match that; and, it updates the dependency on helm.sh/helm/v3 to v3.20 to match that.

This requires updating the Go dependency to 1.25.

And, these three upgrades pull in updates to a dozen other direct dependencies and 30+ indirect dependencies.

So, while this change intentionally targets only the go.mod file, the go.sum file and about 2000 files in the vendor/ subdirectory are changed as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@webbnh webbnh marked this pull request as ready for review March 19, 2026 13:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2026
@webbnh

This comment was marked as resolved.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2026

@webbnh: This pull request references CONSOLE-5134 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sowmya-sl
Copy link
Contributor

/verified by @sowmya-sl

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 19, 2026
@openshift-ci-robot
Copy link
Contributor

@sowmya-sl: This PR has been marked as verified by @sowmya-sl.

Details

In response to this:

/verified by @sowmya-sl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and rhamilto March 19, 2026 14:05
@webbnh
Copy link
Author

webbnh commented Mar 19, 2026

/retest

1 similar comment
@webbnh
Copy link
Author

webbnh commented Mar 20, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

@webbnh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console acb6451 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@webbnh
Copy link
Author

webbnh commented Mar 20, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants