OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct#2447
OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct#2447dinhxuanvu wants to merge 2 commits into
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
dinhxuanvu
changed the title
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bertinatto PTAL |
dinhxuanvu
force-pushed
the
mapped-image
branch
from
04ebfde to
ceed810
Compare
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@bertinatto PTAL. Let me know if this looks more like what you have in mind. Also, I assume we are gonna make changes on extension package directly to openshift-tests-extension repo instead of here? |
dinhxuanvu
changed the title
|
@stbenjam PTAL |
bertinatto
left a comment
bertinatto
left a comment
There was a problem hiding this comment.
This currently doesn't only set the new field, but it overrides the original struct as well.
dinhxuanvu
force-pushed
the
mapped-image
branch
from
ceed810 to
473fe21
Compare
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@bertinatto @stbenjam @smg247 PTAL |
dinhxuanvu
force-pushed
the
mapped-image
branch
from
473fe21 to
feac727
Compare
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
dinhxuanvu
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@dinhxuanvu: This pull request references Jira Issue OCPBUGS-61465, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
dinhxuanvu
force-pushed
the
mapped-image
branch
from
feac727 to
370a1bf
Compare
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-merge-robot
removed
the
needs-rebase
|
@bertinatto PTAL. Thanks. |
|
@bertinatto: This PR was included in a payload test run from openshift/origin#30319
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/29a7cf10-c952-11f0-8f49-cbdc43e1a601-0 |
bertinatto
left a comment
bertinatto
left a comment
There was a problem hiding this comment.
Please use <drop> for the dependency bump and <carry> for the k8s-tests.go change. Also, the latter contains a change in vendor/, which I think is an oversight.
dinhxuanvu
force-pushed
the
mapped-image
branch
from
ec2438d to
3129b2c
Compare
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
dinhxuanvu
force-pushed
the
mapped-image
branch
from
3129b2c to
5cf5e18
Compare
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Done |
dinhxuanvu
force-pushed
the
mapped-image
branch
from
5cf5e18 to
1317ebb
Compare
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
go work vendor Signed-off-by: Vu Dinh <vudinh@outlook.com>
…on Image struct The new field Mapped contains all the same fields of Image resource that can be used later for openshift-tests images cmd to parse this Mapped key. The k8s-tests-ext will construct this Mapped key from GetMappedImageConfigs() function from upstream. Signed-off-by: Vu Dinh <vudinh@outlook.com>
dinhxuanvu
force-pushed
the
mapped-image
branch
from
1317ebb to
b22f2a0
Compare
|
@dinhxuanvu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@dinhxuanvu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest required |
|
@davegord: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test required |
|
@davegord: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
Bot
added
lifecycle/rotten
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6 participants
The current GetMappedImageConfigs returns the map with only mapped image config. The new func GetImageConfigsWithMappedImage will return original image information along with mapped one.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: