OCPBUGS-83872: pkg/cli/admin/upgrade: Tighten force warnings

[openshift-cherrypick-robot]

This is an automated cherry-pick of #2146

/assign openshift-cherrypick-robot

[openshift-ci-robot]

@openshift-cherrypick-robot: Failed to create a cherry-pick bug in Jira: An error was encountered searching for bug OCPBUGS-65757 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

invalid character '<' looking for beginning of value: file already closed

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

This is an automated cherry-pick of #2146

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ardaguclu]

/label backport-risk-assessed

[oarribas]

/jira refresh
/retest

[openshift-ci-robot]

@oarribas: This pull request references Jira Issue OCPBUGS-65757, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• expected dependent Jira Issue OCPBUGS-65481 to target a version in 4.19.0, 4.19.z, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	42c8136	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[oarribas]

The jira creation failed, and it is still linked to the 4.19 one. I don't know if there is any command to re-try the jira creation.

[wking]

/jira refresh

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-65757, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• expected dependent Jira Issue OCPBUGS-65481 to target a version in 4.19.0, 4.19.z, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wking]

Pick the 4.19.z OCPBUGS-65757 (which got this patch in #2146) back to 4.18.z:

/jira cherrypick OCPBUGS-65757

[openshift-ci-robot]

@wking: An error was encountered cloning bug for cherrypick for bug OCPBUGS-65757 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details.

Full error message.

request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":["QA Contact: User 'Jia Liu' is not valid for this user picker."],"errors":{"customfield_10470":"User 'Jia Liu' is not valid for this user picker."}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Pick the 4.19.z OCPBUGS-65757 (which got this patch in #2146) back to 4.18.z:

/jira cherrypick OCPBUGS-65757

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wking]

/retitle OCPBUGS-83872: pkg/cli/admin/upgrade: Tighten force warnings

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-83872, which is invalid:

• expected dependent Jira Issue OCPBUGS-65757 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2146

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wking]

/jira refresh

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-83872, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-65757 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-65757 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiajliu@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wking]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/cli/admin/upgrade/OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

Following @jiajliu's verification process:

$ git checkout origin/pr/2165
$ go build ./cmd/oc
$ ./oc adm upgrade --help|grep -A5 "Cluster-side guards"
 Cluster-side guards include checks for release verification and upgradeable conditions. You can push through them with --force, which is passed through to ClusterVersion's spec.desiredUpdate.force, but only do that if:

  *  you are testing unsigned release images in short-lived test clusters or
  *  you are working around a known bug in the cluster-version operator and you have verified the authenticity of the provided image yourself.

 The provided image will run with full administrative access to the cluster. Do not use --force with images that come from unknown or potentially malicious sources.
$ ./oc adm upgrade --allow-explicit-upgrade --to-image registry.ci.openshift.org/ocp/release@sha256:44f596dfa0ab5e7c02d0261eb90bc5307a825a82927032419fefd7d2c6ebc450 --force
warning: The requested upgrade image is not one of the available updates. You have used --allow-explicit-upgrade for the update to proceed anyway
warning: --force overrides cluster verification of your supplied release image and waives any update precondition failures. Only use this if you are testing unsigned release images or you are working around a known bug in the cluster-version operator and you have verified the authenticity of the provided image yourself.
...

Looks good.

/verified by @wking

[openshift-ci-robot]

@wking: This PR has been marked as verified by @wking.

Details

In response to this:

Following @jiajliu's verification process:

$ git checkout origin/pr/2165
$ go build ./cmd/oc
$ ./oc adm upgrade --help|grep -A5 "Cluster-side guards"
Cluster-side guards include checks for release verification and upgradeable conditions. You can push through them with --force, which is passed through to ClusterVersion's spec.desiredUpdate.force, but only do that if:

 *  you are testing unsigned release images in short-lived test clusters or
 *  you are working around a known bug in the cluster-version operator and you have verified the authenticity of the provided image yourself.

The provided image will run with full administrative access to the cluster. Do not use --force with images that come from unknown or potentially malicious sources.
$ ./oc adm upgrade --allow-explicit-upgrade --to-image registry.ci.openshift.org/ocp/release@sha256:44f596dfa0ab5e7c02d0261eb90bc5307a825a82927032419fefd7d2c6ebc450 --force
warning: The requested upgrade image is not one of the available updates. You have used --allow-explicit-upgrade for the update to proceed anyway
warning: --force overrides cluster verification of your supplied release image and waives any update precondition failures. Only use this if you are testing unsigned release images or you are working around a known bug in the cluster-version operator and you have verified the authenticity of the provided image yourself.
...

Looks good.

/verified by @wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-83872
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-83872 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #2146

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in release 4.18.0-0.nightly-2026-04-21-225743