WIP: haproxy-config.template: Use PROXY protocol v2#391
WIP: haproxy-config.template: Use PROXY protocol v2#391Miciah wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci
Bot
added
the
approved
Miciah
force-pushed
the
haproxy-config-dot-template-use-PROXY-protocol-v2
branch
from
eafd0ab to
bd37a97
Compare
* images/router/haproxy/conf/haproxy-config.template: Use PROXY protocol v2 for the internal "be_sni" and "be_no_sni" backends and "fe_no_sni" and "fe_sni" frontends.
Miciah
force-pushed
the
haproxy-config-dot-template-use-PROXY-protocol-v2
branch
from
bd37a97 to
c755f04
Compare
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
Bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@Miciah: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
removed
the
approved
|
@Miciah: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Looks a fair update and it is currently in a good timing (start of a new release). It marginally improves performance and should not have any backward incompatibility - HAProxy itself is handling the changed request, and a proxy-proto aware frontend handles both v1 and v2. /lgtm |
|
I still need to create a Jira tracker for this PR. |
3 participants
images/router/haproxy/conf/haproxy-config.template: Use PROXY protocol v2 for the internal "be_sni" and "be_no_sni" backends and "fe_no_sni" and "fe_sni" frontends.