OCPBUGS-84323: log the reason why dcm failed

[jcmoraisjr]

Template plugin calls DCM to try dynamically update HAProxy state. In case the dynamic update fails, an internal flag is raised to instruct the template plugin to reload the new configuration on a new HAProxy process. The reason of the failure is logged, however its level is above the default log verbosity, making it not to be added in the router logs. Since this is an exception scenario, those failures are being added on the default log verbosity in order to help debug some environment misbehavior.

https://redhat.atlassian.net/browse/OCPBUGS-84323

Summary by CodeRabbit

• Chores
  • Improved logging visibility for configuration management errors during route operations. Error-related log messages now appear at higher verbosity levels to aid in troubleshooting when dynamic configuration updates fail.

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-84323, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Template plugin calls DCM to try dynamically update HAProxy state. In case the dynamic update fails, an internal flag is raised to instruct the template plugin to reload the new configuration on a new HAProxy process. The reason of the failure is logged, however its level is above the default log verbosity, making it not to be added in the router logs. Since this is an exception scenario, those failures are being added on the default log verbosity in order to help debug some environment misbehavior.

https://redhat.atlassian.net/browse/OCPBUGS-84323

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: daaad3ba-dda4-4904-bae6-99e4459cb653

📥 Commits

Reviewing files that changed from the base of the PR and between 8963907 and 876d908.

📒 Files selected for processing (1)

• pkg/router/template/router.go

---

Walkthrough

Adjusted verbosity levels in error-path logging statements from V(4) to V(0) in the template router when the dynamic configuration manager fails to add, replace, or remove routes and backend endpoints. Control flow remains unchanged.

Changes

Cohort / File(s)	Summary
Error logging verbosity adjustment pkg/router/template/router.go	Changed error-path log statement verbosity from V(4) to V(0) for five failure scenarios: route addition, route endpoint replacement, route removal, backend endpoint replacement, and backend endpoint removal.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'OCPBUGS-84323: log the reason why dcm failed' clearly summarizes the main change: adjusting log levels to surface DCM failure reasons in router logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The custom check regarding stable and deterministic Ginkgo test names is not applicable to this PR. Only production code in pkg/router/template/router.go was modified; no Ginkgo test files or test name definitions were changed.
Test Structure And Quality	✅ Passed	PR adjusts log verbosity levels in production code with no test code modifications, making custom check not applicable.
Microshift Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests. The changes are limited to adjusting log verbosity levels in pkg/router/template/router.go for error-path logging. Since the MicroShift Test Compatibility check only applies to new test additions, this check is not applicable and passes.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Pull request only modifies logging levels in router configuration code and does not add any new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only modifies logging verbosity in router.go; no scheduling constraints or topology-specific deployment changes are introduced.
Ote Binary Stdout Contract	✅ Passed	PR changes log verbosity levels in library code (pkg/router/template/router.go), not in process-level initialization code, so it does not violate the OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies logging statements in an existing source file without adding any new Ginkgo e2e tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-84323, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

Template plugin calls DCM to try dynamically update HAProxy state. In case the dynamic update fails, an internal flag is raised to instruct the template plugin to reload the new configuration on a new HAProxy process. The reason of the failure is logged, however its level is above the default log verbosity, making it not to be added in the router logs. Since this is an exception scenario, those failures are being added on the default log verbosity in order to help debug some environment misbehavior.

https://redhat.atlassian.net/browse/OCPBUGS-84323

Summary by CodeRabbit

• Chores
• Improved logging visibility for configuration management errors during route operations. Error-related log messages now appear at higher verbosity levels to aid in troubleshooting when dynamic configuration updates fail.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jcmoraisjr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade	876d908	link	true	/test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bentito]

/assign @gcs278