Skip to content

[docs] Declare support for windows server 2025#4091

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
mansikulkarni96:2025_docs
May 13, 2026
Merged

[docs] Declare support for windows server 2025#4091
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
mansikulkarni96:2025_docs

Conversation

@mansikulkarni96
Copy link
Copy Markdown
Member

@mansikulkarni96 mansikulkarni96 commented May 13, 2026

Summary by CodeRabbit

  • Documentation
    • Updated documentation to include Windows Server 2025 support information across prerequisites, configuration examples, workload guidance, and testing resources.

@mansikulkarni96
Copy link
Copy Markdown
Member Author

/cherry-pick release-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mansikulkarni96: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e0d24bf1-6c97-48bf-83f3-8d77d776f3f2

📥 Commits

Reviewing files that changed from the base of the PR and between 811daee and df86905.

📒 Files selected for processing (4)
  • docs/HACKING.md
  • docs/machineset-nutanix.md
  • docs/windows-workloads.md
  • docs/wmco-prerequisites.md

📝 Walkthrough

Walkthrough

This pull request extends documentation across four files to incorporate Windows Server 2025 support. The e2e test CLI flag documentation in docs/HACKING.md now includes 2025 as an allowed option. The Nutanix machineset documentation in docs/machineset-nutanix.md clarifies the placeholder with multiple versioned examples. Windows workload documentation in docs/windows-workloads.md adds RuntimeClass naming guidance (windows2025 with build value 10.0.26100) and container image references for 2025. Finally, docs/wmco-prerequisites.md updates both the "Supported Windows Server versions" table and the hybrid OVNKubernetes networking table to include Windows Server 2025 LTSC entries across cloud providers and networking configurations.

Suggested reviewers

  • jrvaldes
🚥 Pre-merge checks | ✅ 17
✅ Passed checks (17 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the changeset: adding Windows Server 2025 support documentation across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Best Practices & Build Tags ✅ Passed PR contains only documentation changes (Markdown files). No Go source code was modified, so Go best practices and build tag checks are not applicable.
Security: Secrets, Ssh & Csr ✅ Passed PR is documentation-only for Windows Server 2025 support. No changes to security-related code (secrets, SSH, CSR, certificates). No credentials, keys, or sensitive data exposed. Check not applicable.
Kubernetes Controller Patterns ✅ Passed Not applicable: This PR contains only documentation changes (4 markdown files). The Kubernetes Controller Patterns check applies to Go controller code, which is absent from this PR.
Windows Service Management ✅ Passed PR is documentation-only (4 docs files, +18/-14 lines). No code changes to service management. Service management code is completely unchanged. Check not applicable.
Platform-Specific Requirements ✅ Passed PR adds Windows Server 2025 to supported documentation. Does not introduce new platform-specific constraints or technical requirements for 2025 beyond existing 2022 support.
Stable And Deterministic Test Names ✅ Passed PR modifies only documentation files (4 .md files). The custom check applies to Ginkgo test suites and Go test files, neither of which are modified. Check not applicable to this PR.
Test Structure And Quality ✅ Passed PR contains only documentation changes to 4 files. No test files modified. Ginkgo test code review check is not applicable.
Microshift Test Compatibility ✅ Passed PR contains only documentation changes (4 markdown files). No new Ginkgo e2e tests added. Custom check is only applicable when new tests are introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Check is not applicable. This PR contains only documentation updates (4 markdown files) with no new Ginkgo e2e tests. The SNO compatibility check applies only when new tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed Documentation-only changes declaring Windows Server 2025 support. No deployment manifests, operator code, or controllers modified. Check not applicable.
Ote Binary Stdout Contract ✅ Passed PR contains only documentation changes (4 markdown files). No Go source files or process-level code modified. OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only documentation updates (no Ginkgo e2e tests). Custom check applies only when new test code is added. Check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested a review from jrvaldes May 13, 2026 14:25
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jrvaldes,mansikulkarni96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@mansikulkarni96: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 6b3dcab into openshift:master May 13, 2026
3 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown

@mansikulkarni96: new pull request created: #4092

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants