Introduce GenAI parser adapter#4054
Draft
mzegla wants to merge 1 commit into
Draft
Conversation
dkalinowski
reviewed
Apr 13, 2026
| class Llama3OutputParserTest : public ::testing::Test { | ||
| // Parametrized fixture — runs every test with both "llama3" (native) and "llama3_genai" (adapter) parsers. | ||
| // | ||
| // Known behavioral differences between "llama3" and "llama3_genai": |
Collaborator
There was a problem hiding this comment.
So we drop support for a case where model generates text and tools separated by <|python_tag|>?
abcd abcd <|python_tag|> tools...
Isnt it big issue?
dkalinowski
reviewed
Apr 13, 2026
| incrementalParser(std::move(incrementalParser)) {} | ||
|
|
||
| // static | ||
| void GenAIParserAdapter::extractToolCalls(const ov::genai::JsonContainer& message, ToolCalls_t& toolCalls) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| void GenAIParserAdapter::extractToolCalls(const ov::genai::JsonContainer& message, ToolCalls_t& toolCalls) { | |
| ToolCalls_t GenAIParserAdapter::extractToolCalls(const ov::genai::JsonContainer& message) { |
Why not just work with return value?
dkalinowski
reviewed
Apr 13, 2026
| if (fn.contains("name") && fn["name"].is_string()) { | ||
| toolCall.name = fn["name"].get_string(); | ||
| } | ||
| if (fn.contains("arguments") && fn["arguments"].is_string()) { |
Collaborator
There was a problem hiding this comment.
plenty of checks do not return an error, but silently continue. is it good idea?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an adapter class to bridge OVMS output parsing machinery and GenAI parsers interface + Llama3 parser implementation via this adapter.