Repository navigation
test(session): a /proc file of a child reaped mid-read is gone, not an exception - #703
Merged
Merged
Conversation
…n exception main's unit (5/6) on 8526694 failed SessionWakeup.AColdChildExitsWithout- WaitingForTheControlPollTick with "basic_filebuf::underflow error reading the file: No such process". The child was reaped between the open of /proc/<pid>/stat and its read; libstdc++ throws on that read's ESRCH. The loop already takes an empty read as the child gone; the read now says so. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's
unit (5/6)failed on 8526694 (#702's merge; the rerun is under way):The test polls
/proc/<child>/statuntil the child is a zombie, or gone. When init reaps the child between the file's open and its read, the read fails withESRCH, and libstdc++ throws on it. The loop already treats an empty read as "gone", so the test'sreadnow returns empty in that case too.The flake is in the test only, so there's no version bump.
Co-authored-by: speak-agent 248744407+speak-agent@users.noreply.github.com