Skip to content

test(session): a /proc file of a child reaped mid-read is gone, not an exception - #703

Merged
Sunrisepeak merged 1 commit into
mainfrom
fix/session-wakeup-proc-race
Oct 23, 2026
Merged

Sunrisepeak merged 1 commit into
mainfrom
fix/session-wakeup-proc-race

Conversation

@Sunrisepeak

Copy link
Copy Markdown
Member

main's unit (5/6) failed on 8526694 (#702's merge; the rerun is under way):

[ RUN      ] SessionWakeup.AColdChildExitsWithoutWaitingForTheControlPollTick
C++ exception with description "basic_filebuf::underflow error reading the file: No such process" thrown in the test body.

The test polls /proc/<child>/stat until the child is a zombie, or gone. When init reaps the child between the file's open and its read, the read fails with ESRCH, and libstdc++ throws on it. The loop already treats an empty read as "gone", so the test's read now returns empty in that case too.

The flake is in the test only, so there's no version bump.

Co-authored-by: speak-agent 248744407+speak-agent@users.noreply.github.com

…n exception

main's unit (5/6) on 8526694 failed SessionWakeup.AColdChildExitsWithout-
WaitingForTheControlPollTick with "basic_filebuf::underflow error reading the
file: No such process". The child was reaped between the open of
/proc/<pid>/stat and its read; libstdc++ throws on that read's ESRCH. The loop
already takes an empty read as the child gone; the read now says so.

Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
@Sunrisepeak
Sunrisepeak merged commit 523ebf1 into main Oct 23, 2026
34 checks passed
Sunrisepeak added a commit that referenced this pull request Oct 23, 2026
…); an image boots on the monitor its home installs (J52) (#704)

Version bump to 2026.10.24.1: #702 (J51, J52, the domain check's one sentence for every refusal) and #703 (a test's /proc read race) on top of 2026.10.23.2.

Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant