Skip to content

Backport wabac.JS change around rewriting: detect when JS is in 'strict' mode and avoid using 'arguments'#286

Merged
benoit74 merged 2 commits intomainfrom
backport
Mar 16, 2026
Merged

Backport wabac.JS change around rewriting: detect when JS is in 'strict' mode and avoid using 'arguments'#286
benoit74 merged 2 commits intomainfrom
backport

Conversation

@benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Mar 16, 2026

@benoit74 benoit74 self-assigned this Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.52%. Comparing base (a2145be) to head (f8b337b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/zimscraperlib/rewriting/js.py 86.95% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   99.63%   99.52%   -0.12%     
==========================================
  Files          41       41              
  Lines        2496     2516      +20     
  Branches      347      354       +7     
==========================================
+ Hits         2487     2504      +17     
- Misses          7        8       +1     
- Partials        2        4       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 merged commit ac1fbd9 into main Mar 16, 2026
7 of 9 checks passed
@benoit74 benoit74 deleted the backport branch March 16, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant