Repository navigation
fix: apply merged config to the CODEOWNERS requirement - #928
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
The CODEOWNERS check reads oc.RequireCODEOWNERS straight off the org config, so it never goes through mergeConfig. Both repo-level settings, the one in the org config repo under <repo>/codeowners.yaml and the one in the checked repo's own .allstar folder, are parsed into mergedConfig.RequireCODEOWNERS and then ignored. Every other policy merges first and reads the merged value, and GetAction in this file already does. mergeConfig still gates the repo's own config on disableRepoOverride, so an org that locks the setting keeps it. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkreadsoc.RequireCODEOWNERSstraight off the org config, so it never goes throughmergeConfig. That meansrequireCODEOWNERSset per repo, either in the org config repo under<repo>/codeowners.yamlor in the checked repo's own.allstarfolder, is parsed intomergedConfig.RequireCODEOWNERSand then ignored. Every other policy merges first and reads the merged value, andGetActionin this same file already does.Switching the one read to
mc.RequireCODEOWNERSis the whole fix.mergeConfigstill gates the repo's own config ondisableRepoOverride, so an org that locks the setting keeps it. Three cases added toTestCheckcover a repo turning the requirement on, a repo turning it off, and the locked case; the first two fail on main.go test ./...passes.AI assistance was used on this change and is disclosed in the commit trailer.