AO3-4274 Display relations to deleted works#5710
Open
luis-pabon-tf wants to merge 18 commits intootwcode:masterfrom
Open
AO3-4274 Display relations to deleted works#5710luis-pabon-tf wants to merge 18 commits intootwcode:masterfrom
luis-pabon-tf wants to merge 18 commits intootwcode:masterfrom
Conversation
brianjaustin
requested changes
Apr 19, 2026
| </dt> | ||
| <dd class="parent"> | ||
| <%= label_tag "parent-options-show", ts("This work is a remix, a translation, a podfic, or was inspired by another work") %> | ||
| <%= label_tag "parent-options-show", t("works.associations.parent.header") %> |
Member
There was a problem hiding this comment.
Per our internationalization standards, lazy keys (starting with a . and omitting the name of the view/partial) are preferred. I remember that some places, most importantly helpers/callbacks, don't work with that, but IIRC a partial like this should still work.
Contributor
Author
|
Thanks for the feedback! I will take care of these this week :) |
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
sarken
reviewed
May 4, 2026
| <ul class="actions" role="navigation"> | ||
| <li> | ||
| <dd> | ||
| <ul class="actions" role="navigation"> |
Collaborator
There was a problem hiding this comment.
When it's time to resolve the merge conflicts on this PR, could you remove this role attribute? It's not a valid role for a ul element, so we're trying to remove them whenever we come across them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-4274
Purpose
Fixes display issues that happen on the Work/Edit Work/Downloaded pages when there's a relationship with a different Work, and then that other Work is deleted.
The PR also includes translatable entries where code was added or edited.
References
https://otwarchive.atlassian.net/browse/AO3-7349 - These issues are pretty close to each other. These changes should help tackle that one too.
Credit
Luis Pabon (they/he)