AO3-7410 Fix the inconsistency in the site name on the page title for works and series#5766
Open
CelineB-sudo wants to merge 2 commits intootwcode:masterfrom
Open
AO3-7410 Fix the inconsistency in the site name on the page title for works and series#5766CelineB-sudo wants to merge 2 commits intootwcode:masterfrom
CelineB-sudo wants to merge 2 commits intootwcode:masterfrom
Conversation
… works and series
marcus8448
reviewed
May 8, 2026
Member
marcus8448
left a comment
marcus8448
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| end | ||
|
|
||
| page_title += " [#{ArchiveConfig.APP_NAME}]" unless options[:omit_archive_name] | ||
| page_title += " | #{ArchiveConfig.APP_NAME}" unless options[:omit_archive_name] |
Member
There was a problem hiding this comment.
I think it would be a bit nicer to stop appending the app name altogether in this function, and instead update all of its uses to set @page_subtitle instead of @page_title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7410
Purpose
What does this PR do?
It resolves the inconsistency in the page titles for works and series. The browser page title had the site name formatted as "[App Name]," but every other page uses the format "| App Name."
Now, all pages use the format “| App Name”.
The tests have been updated to reflect the changes.
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
Céline Bertaud (she/her)