AO3-7409 Adjust header and page subtitle for managing invitations

[jmalark]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7409

Purpose

On the manage invitations page, adjusts the browser subtitle and the header

Credit

Jesse Malark he/him

[sarken]

Can you make these page_heading.admin and page_heading.user, please? It should look like this in the locale file:

manage:
  page_heading:
    admin: text
    user: text

And apologies for not catching this before, but the current code will define the username variable even when we don't need it. It's not terrible, but it would be better to do something like

<h2 class="heading">
  <% if logged_in_as_admin? %>
    <%= t(".page_heading.admin", username: @user.login) %>
  <% else %>
    [etc]

That would also mean i18n-tasks unused -l en should pass without needing to add anything to ignore_unused.

[jmalark]

If we are adding an if / else condition, should I also be making the text more like displaying base text for user and base text + admin text for admin or would trying to name those things make the code less clear?

[sarken]

Whoops, sorry, didn't see this question before I approved the pull request! But in general, it's a good idea to avoid doing that. Just because "Manage Invitations" and "for username" combine nicely into "Manage Invitations for username" English doesn't mean it will work across all languages. It's easier for the translation team to have the versions entirely separate like we've done here.

[sarken]

Thank you!