AO3-7431 Remove incorrect role="menu" from work form subnavigation#5786
AO3-7431 Remove incorrect role="menu" from work form subnavigation#5786manemuradyannnn wants to merge 2 commits intootwcode:masterfrom
Conversation
|
Hi, Mane Muradyan! Thank you so much for this pull request. Someone will be along to review it soon. In the meantime, we've set the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
techlingyi
left a comment
There was a problem hiding this comment.
Hi! Not an official review, just stopping by as a fellow contributor.
|
|
||
| <!--subnav--> | ||
| <ul class="navigation actions" role="menu"> | ||
| <ul class="navigation actions">> |
There was a problem hiding this comment.
There's an extra > in this line that should be removed — otherwise, this pull request looks good to me!
There was a problem hiding this comment.
Hi!! Thank you so much. Just fixed the error :)
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7431
Purpose
This PR removes the incorrect
role="menu"ARIA attribute from the sub navigationelements on the new work, edit work, and import work forms as follows:
app/views/works/new.html.erbapp/views/works/edit.html.erbapp/views/works/new_import.html.erbCredit
[Mane Muradyan], [she/her]