Skip to content

AO3-7431 Remove incorrect role="menu" from work form subnavigation#5786

Open
manemuradyannnn wants to merge 2 commits intootwcode:masterfrom
manemuradyannnn:fix/remove-menu-role-work-forms
Open

AO3-7431 Remove incorrect role="menu" from work form subnavigation#5786
manemuradyannnn wants to merge 2 commits intootwcode:masterfrom
manemuradyannnn:fix/remove-menu-role-work-forms

Conversation

@manemuradyannnn
Copy link
Copy Markdown

@manemuradyannnn manemuradyannnn commented May 5, 2026

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7431

Purpose

This PR removes the incorrect role="menu" ARIA attribute from the sub navigation

    elements on the new work, edit work, and import work forms as follows:

    • app/views/works/new.html.erb
    • app/views/works/edit.html.erb
    • app/views/works/new_import.html.erb

    Credit

    [Mane Muradyan], [she/her]

@sarken
Copy link
Copy Markdown
Collaborator

sarken commented May 5, 2026

Hi, Mane Muradyan!

Thank you so much for this pull request. Someone will be along to review it soon.

In the meantime, we've set the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

Copy link
Copy Markdown
Contributor

@techlingyi techlingyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Not an official review, just stopping by as a fellow contributor.

Comment thread app/views/works/new_import.html.erb Outdated

<!--subnav-->
<ul class="navigation actions" role="menu">
<ul class="navigation actions">>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra > in this line that should be removed — otherwise, this pull request looks good to me!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!! Thank you so much. Just fixed the error :)

@Bilka2 Bilka2 mentioned this pull request May 6, 2026
5 tasks
manemuradyannnn added a commit to manemuradyannnn/otwarchive that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants