AO3-5713 fix tag set fandom only validation#5790
Open
pmonfort wants to merge 2 commits intootwcode:masterfrom
Open
AO3-5713 fix tag set fandom only validation#5790pmonfort wants to merge 2 commits intootwcode:masterfrom
pmonfort wants to merge 2 commits intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-5713
Purpose
The "Tag set fandom only?" option (
character_restrict_to_tag_set/relationship_restrict_to_tag_set) on challenge prompt restrictions only controls the autocomplete suggestions in the signup form, but does not actually validate on the server side. Users can bypass the autocomplete by typing a tag name manually and submit characters or relationships that are canonical in the fandom but not in the tag set.This PR adds server-side validation in
Prompt#restricted_tagsso that whenrestrict_to_tag_setis enabled, allowed tags are further filtered to only those present in the tag set associations for the selected fandom. It reuses thetag_set_associationsscope already set up by the AO3-5712 fix.Testing Instructions
Credit
Pablo Monfort (he/him)