AO3-6978 Create and fill new table for import urls#5795
Open
luis-pabon-tf wants to merge 27 commits intootwcode:masterfrom
Open
AO3-6978 Create and fill new table for import urls#5795luis-pabon-tf wants to merge 27 commits intootwcode:masterfrom
luis-pabon-tf wants to merge 27 commits intootwcode:masterfrom
Conversation
Used co-authors work as reference when making this migration Co-Authored-By: Éric B. <896729+ceithir@users.noreply.github.com> Co-Authored-By: Melissa Jiménez <96195033+gmjimenezc@users.noreply.github.com>
…mine Co-Authored-By: Melissa Jiménez <96195033+gmjimenezc@users.noreply.github.com>
…d test case for importedUrl handling of longer urls
github-actions
Bot
added
Has Migrations
sarken
requested changes
May 9, 2026
Collaborator
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| work.imported_url = ImportedUrl.create(original: work.imported_from_url) | ||
| begin | ||
| work.imported_url = ImportedUrl.create(original: work.imported_from_url) | ||
| rescue StandardError => e |
Collaborator
There was a problem hiding this comment.
Could you update spec/lib/tasks/work_import_urls.rake_spec.rb with a test that shows the output for the error?
| t.string :minimal_no_protocol_no_www, null: false | ||
| t.string :no_www, null: false | ||
| t.string :with_www, null: false | ||
| t.string :with_www, null: false, limit: 300 |
Collaborator
There was a problem hiding this comment.
Could you add a comment documentation why these are the chosen values for these limits?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6978
Purpose
Step 1 of moving imported URLs to a new table to store all searchable variations.
References
This is a follow-up to PR 5659 as that had issues during the production backfill.
AO3-6979 follows up on this one
AO3-6591 Is the parent both tickets belong to
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
Luis Pabon (they/he)