AO3-7413 Unify new external bookmark page naming#5796
AO3-7413 Unify new external bookmark page naming#5796gemmie wants to merge 5 commits intootwcode:masterfrom
Conversation
sarken
left a comment
There was a problem hiding this comment.
Hi, gemmie!
Thank you so much for this pull request. I've given it a quick look and left one comment that need needs action.
I've also updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."
Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.
Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.
| works_languages_help_title: Languages help | ||
| new: | ||
| page_heading: Bookmark External Work | ||
| page_title: Bookmark External Work |
There was a problem hiding this comment.
Since page_title is used in the controller, it should go in config/locales/controllers/en.yml instead. (The page_heading can stay here.)
There was a problem hiding this comment.
is there a better place for the page_heading as well?
|
Hi, thank you! I do have a Jira profile, the name matches my data on my github profile (email: k.tynka96@gmail.com, full name: Kat Tynka, public name: gemmie). I would prefer to be credited as gemmie if that's okay with you :) |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7413
Purpose
What does this PR do?
Unifies page title and header naming, when creating a new External Work Bookmark.
Testing Instructions
Log in
Hi, username! > My Dashboard > Bookmarks > Bookmark External Work
The page tile on the browser tab should say: Bookmark External Work | Archive of Our Own.
The header (
h2) should say: Bookmark External WorkCredit
gemmie she/her