Skip to content

AO3-7413 Unify new external bookmark page naming#5796

Open
gemmie wants to merge 5 commits intootwcode:masterfrom
gemmie:AO3-7413-external-bookmark-naming
Open

AO3-7413 Unify new external bookmark page naming#5796
gemmie wants to merge 5 commits intootwcode:masterfrom
gemmie:AO3-7413-external-bookmark-naming

Conversation

@gemmie
Copy link
Copy Markdown

@gemmie gemmie commented May 8, 2026

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7413

Purpose

What does this PR do?

Unifies page title and header naming, when creating a new External Work Bookmark.

Testing Instructions

Log in

Hi, username! > My Dashboard > Bookmarks > Bookmark External Work

The page tile on the browser tab should say: Bookmark External Work | Archive of Our Own.
The header (h2) should say: Bookmark External Work

Credit

gemmie she/her

@gemmie gemmie changed the title AO3-7413 new external bookmark naming AO3-7413 Unify new external bookmark page naming May 8, 2026
Copy link
Copy Markdown
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, gemmie!

Thank you so much for this pull request. I've given it a quick look and left one comment that need needs action.

I've also updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

Comment thread config/locales/views/en.yml Outdated
works_languages_help_title: Languages help
new:
page_heading: Bookmark External Work
page_title: Bookmark External Work
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since page_title is used in the controller, it should go in config/locales/controllers/en.yml instead. (The page_heading can stay here.)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a better place for the page_heading as well?

@gemmie
Copy link
Copy Markdown
Author

gemmie commented May 9, 2026

Hi, thank you!

I do have a Jira profile, the name matches my data on my github profile (email: k.tynka96@gmail.com, full name: Kat Tynka, public name: gemmie). I would prefer to be credited as gemmie if that's okay with you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants