Repository navigation
fix: export table and MUI types, add label prop to Checkbox and Toggle - #118
Merged
Merged
Conversation
Signed-off-by: psterpu-c <psterpu@cisco.com>
Signed-off-by: psterpu-c <psterpu@cisco.com>
Signed-off-by: psterpu-c <psterpu@cisco.com>
Signed-off-by: psterpu-c <psterpu@cisco.com>
Member
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Exposes more of the public surface without needing the underlying libraries, and brings
CheckboxandTogglein line withRadioButtonfor labels. All changes are additive.TableSortingState,TableRowSelectionState,TableVisibilityState,TablePaginationState,TableColumnPinningState,TableColumnDef,TableRowModel,TableCellModel,TableInstance) and re-exports ofSxProps,Theme,SvgIconPropsandSystemStyleObject.labelandformControlLabelPropsprops, with label styling shared withRadioButtonthrough one helper (getControlLabelStylesintheme/style/common.tsx). Withoutlabel, both render exactly as before.downloadandreloadDocumentwork. No component changes..cursorin.gitignore.🔗 Related Issue
Closes #
🧪 Type of Change
🧪 Testing
yarn test --testPathPattern=<component-or-area>)yarn lint && yarn typecheck)yarn storybook:build)Test Instructions:
yarn workspace @open-ui-kit/core test src/components/checkbox src/components/toggle src/components/radio src/components/linkyarn workspace @open-ui-kit/core typecheck && yarn workspace @open-ui-kit/core lintyarn storybook, then open Components/Checkbox and Components/Toggle:labelPlacement: "start").import type { TableSortingState, TableColumnDef, Theme, SxProps } from "@open-ui-kit/core"should resolve.♿ Accessibility
📱 Responsive Design
📚 Documentation
🔄 Breaking Changes
None. The new props are optional and unused elsewhere in the repo.
CheckboxPropsandTogglePropschanged from type aliases to interfaces extending the MUI props, with the same names and exports.📋 Checklist
yarn testwas not run locally📸 Screenshots
Before
After
For Maintainers: