Skip to content

[FEATURE REQUEST] Add action to check source strings#4807

Open
jesmrec wants to merge 4 commits intomasterfrom
feature/add_action_check_source_strings
Open

[FEATURE REQUEST] Add action to check source strings#4807
jesmrec wants to merge 4 commits intomasterfrom
feature/add_action_check_source_strings

Conversation

@jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Mar 16, 2026

Two actions were addressed here:

  • In the strings.xml file, some tiny changes to normalize the file against the validation script: remove some useless line breaks, and replace " for the escaped \"

  • The action will run a script to check if every string in strings.xml contains any forbidden character (non-escaped). The list of forbidden characters is set inside the script (i expect the list to be very static). The util xmlstarlet will be used to parse the xml file and provide every entry one by one by using the process substitution operation

For the moment, the check will not be mandatory. Let's give a try, and, if it works fine, we could become mandatory

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec self-assigned this Mar 16, 2026
@jesmrec jesmrec added this to the 4.8 - Current milestone Mar 16, 2026
@jesmrec jesmrec force-pushed the feature/add_action_check_source_strings branch 4 times, most recently from 7689a00 to 4bc6ef4 Compare March 16, 2026 11:10
@jesmrec jesmrec marked this pull request as ready for review March 16, 2026 11:52
@jesmrec jesmrec force-pushed the feature/add_action_check_source_strings branch from 279583d to 4bc6ef4 Compare March 16, 2026 11:53
@jesmrec jesmrec force-pushed the feature/add_action_check_source_strings branch from 1fa16c4 to cf3a224 Compare March 17, 2026 13:11
@jesmrec jesmrec requested a review from joragua March 17, 2026 15:34
@joragua joragua changed the title [FEATURE] Add action to check source strings [FEATURE REQUEST] Add action to check source strings Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants