Skip to content

[FIX] Exclude SBOM from Conventional commits#4808

Merged
jesmrec merged 4 commits intomasterfrom
fix/exclude_sbom_from_conventional_commits
Mar 17, 2026
Merged

[FIX] Exclude SBOM from Conventional commits#4808
jesmrec merged 4 commits intomasterfrom
fix/exclude_sbom_from_conventional_commits

Conversation

@jesmrec
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec commented Mar 16, 2026

SBOM workflow generates commit with title docs: SBOM updated

That's not compliant with conventional commits because the first letter of the message is a capital, and must be lower case. That causes CI to fail.

Solution: SBOM commits to be ignored in terms of conventional commits.

About changes in SBOM, seems that PhotoView dependency has changed its metadata caught by cycloneDX. We'll put an eye on this, just in case. Dependency is not removed just some of its metadata.

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec self-assigned this Mar 16, 2026
@jesmrec jesmrec force-pushed the fix/exclude_sbom_from_conventional_commits branch 5 times, most recently from 3502902 to 0cd4cbd Compare March 17, 2026 12:00
@jesmrec jesmrec requested a review from joragua March 17, 2026 12:13
@jesmrec jesmrec marked this pull request as ready for review March 17, 2026 12:13
Copy link
Copy Markdown
Contributor

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment 😄

Comment thread .github/workflows/conventional-commits.yml Outdated
@jesmrec jesmrec force-pushed the fix/exclude_sbom_from_conventional_commits branch from a75385c to 0133ef9 Compare March 17, 2026 12:54
@jesmrec jesmrec requested a review from joragua March 17, 2026 13:05
Copy link
Copy Markdown
Contributor

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@jesmrec jesmrec merged commit 12ba9e8 into master Mar 17, 2026
11 checks passed
@jesmrec jesmrec deleted the fix/exclude_sbom_from_conventional_commits branch March 17, 2026 13:10
@joragua joragua added this to the 4.8 - Current milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants