Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a button to IP Pool Cells that opens up a sidebar with more info on the IP Pool.
I think it's a little strange that we have two different actions that both have the same UI — in one, we take the user to a new page, in the other, we open up this sidebar with more info. But if that's an issue, it's larger than this, as we already do both things in various points in the UI. I think it's just more noticeable here because the two kinds of cells are right next to each other in the Floating IP table.
Also, it's worth deciding if we want to stack sidebars, which we could do by making this IP pool cell in the properties table into a link:
The stacking is kind of cool, actually, so we might want to do it, though I also get it if layering those up creates an odd situation for wayfinding / navigation. Note that the IP Pool sidenavs do not currently have their own URLs.
(If we do want to have sidenavs stack, we'll also need to futz with some z-index settings on the component / pass in custom CSS classes and do so from the sidebar callsites, etc.)
Closes #3143