Rename IP pool reservation type#10534
Open
bnaecker wants to merge 5 commits into
Open
Conversation
Collaborator
bnaecker
commented
Jun 2, 2026
bnaecker
commented
- Rename the IP Pool "reservation type" enum to "assignment" and rename the variants. These types will soon appear in public documentation, and these names are clearer and more obvious to customers.
- Database schema / data migration for the rename
- Clean up a bunch of tests, comments, error messages, etc that referred to "reserve" or the "reservation type"
- Rename the IP Pool "reservation type" enum to "assignment" and rename the variants. These types will soon appear in public documentation, and these names are clearer and more obvious to customers. - Database schema / data migration for the rename - Clean up a bunch of tests, comments, error messages, etc that referred to "reserve" or the "reservation type"
mergeconflict
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.