You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Let a caller wrap the client's HTTP handler, to see and refuse each request - #464
Adds MerakiClientOptions.WrapHttpMessageHandler (Func<HttpMessageHandler, HttpMessageHandler>?). The client calls it once at construction with its own AuthenticatedBackingOffHttpClientHandler and builds its three HttpClients (core, SecureConnect, Workflows) on the result, so a caller can see, record and refuse every request. Sitting outside authentication and retries, the wrapper sees one call per request with its final response and never the credentials. Disposing the client disposes it. A wrapper returning null is a ConfigurationException. Unset, nothing changes.
Why: Magic Suite (MS-28068, SOC 2) hands this client to customers' C# scripts and must audit every write, who caused it, its method, path and outcome, and refuse writes itself when they are not permitted. The other PanoramicData API clients will follow the same option name.
Tests: Meraki.Api.Test.Client.WrapHttpMessageHandlerTests (offline: the wrapper sees the request and its answer is the client's answer; a refusal fails the call with its reason; the wrapper is created once around the client's own handler; a null wrapper is a configuration error; disposing the client disposes the wrapper). Red check: with the HttpClients built on the unwrapped handler, the two request tests fail. Release build clean; all 81 tests in Meraki.Api.Test.Client pass.
The changelog entry is headed Unreleased, for the version it ships in. Making IsReadOnly immutable after construction is not part of this change.
…equest (#463)
MerakiClientOptions.WrapHttpMessageHandler is called once at construction with the client's own handler; the three HttpClients share the wrapper, which sits outside authentication and retries.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #463.
Adds
MerakiClientOptions.WrapHttpMessageHandler(Func<HttpMessageHandler, HttpMessageHandler>?). The client calls it once at construction with its ownAuthenticatedBackingOffHttpClientHandlerand builds its threeHttpClients (core, SecureConnect, Workflows) on the result, so a caller can see, record and refuse every request. Sitting outside authentication and retries, the wrapper sees one call per request with its final response and never the credentials. Disposing the client disposes it. A wrapper returningnullis aConfigurationException. Unset, nothing changes.Why: Magic Suite (MS-28068, SOC 2) hands this client to customers' C# scripts and must audit every write, who caused it, its method, path and outcome, and refuse writes itself when they are not permitted. The other PanoramicData API clients will follow the same option name.
Tests:
Meraki.Api.Test.Client.WrapHttpMessageHandlerTests(offline: the wrapper sees the request and its answer is the client's answer; a refusal fails the call with its reason; the wrapper is created once around the client's own handler; a null wrapper is a configuration error; disposing the client disposes the wrapper). Red check: with the HttpClients built on the unwrapped handler, the two request tests fail. Release build clean; all 81 tests inMeraki.Api.Test.Clientpass.The changelog entry is headed Unreleased, for the version it ships in. Making
IsReadOnlyimmutable after construction is not part of this change.