Skip to content

Fix TimerAsync.Stop throwing after an early Start, and bring coverage to 100% - #18

Merged
davidnmbond merged 3 commits into
mainfrom
test/full-coverage
Nov 13, 2026
Merged

davidnmbond merged 3 commits into
mainfrom
test/full-coverage

Conversation

@davidnmbond

Copy link
Copy Markdown
Collaborator

Task.Run was given the cancellation token, so stopping before the scheduled task
began made Stop() throw TaskCanceledException. Adds tests for Engine, TimerAsync,
AsyncTimerEngine and EngineException (100% line and branch), the Microsoft code
coverage collector with coverage.config, xunit.v3 4.0.2 and the MTP runner opt-in.

… to 100%

Task.Run was given the cancellation token, so stopping before the scheduled task
began made Stop() throw TaskCanceledException. Adds tests for Engine, TimerAsync,
AsyncTimerEngine and EngineException (100% line and branch), the Microsoft code
coverage collector with coverage.config, xunit.v3 4.0.2 and the MTP runner opt-in.
@codacy-production

codacy-production Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 61 complexity · 0 duplication

Metric Results
Complexity 61
Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage · +89.00% coverage variation

Metric Results
Coverage variation ✅ +89.00% coverage variation
Diff coverage ✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9562187) 100 11 11.00%
Head commit (b3afb4f) 100 (+0) 100 (+89) 100.00% (+89.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#18) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit 7398aba into main Nov 13, 2026
6 checks passed
@davidnmbond
davidnmbond deleted the test/full-coverage branch November 13, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant