Skip to content

refactor: use a conditional for the two-way field-condition dispatch - #14

Merged
davidnmbond merged 1 commit into
mainfrom
fix/ternary
Nov 9, 2026
Merged

davidnmbond merged 1 commit into
mainfrom
fix/ternary

Conversation

@davidnmbond

Copy link
Copy Markdown
Contributor

Clears Codacy SonarCSharp_S1301 on RuleValidator.FieldConditionError (introduced in #13): a two-arm switch becomes a conditional expression. Behaviour unchanged; validation and rule tests pass.

@codacy-production

codacy-production Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage · 0.00% coverage variation

Metric Results
Coverage variation ✅ 0.00% coverage variation (-1.00%)
Diff coverage ✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fa1e158) 2073 2070 99.86%
Head commit (e600c8c) 2071 (-2) 2068 (-2) 99.86% (0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#14) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit 4c2ee24 into main Nov 9, 2026
7 checks passed
@davidnmbond
davidnmbond deleted the fix/ternary branch November 9, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant