Repository navigation
fix: ignore headings quoted in {noformat} and {code} blocks - #16
Merged
Merged
Conversation
…{code} blocks
Fixes #9. Section, criteria-heading and panel parsing read a masked copy of the text in which the first visible character of each line inside a literal block is blanked; SectionBody still returns the original text.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 18 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (3c13989) 2071 2068 99.86% Head commit (4945ad0) 2099 (+28) 2096 (+28) 99.86% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#16) 32 32 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9.
SectionBody, CriteriaHeadings and PanelLayoutOf now parse a masked copy of the text: on each line inside a {noformat} or {code}/{code:lang} block, the first visible character is blanked, so quoted h2. headings, # list items and | table rows are not read as the ticket's own structure. Length and positions are kept, and SectionBody cuts its result from the original text, so quoted content is returned unchanged. {noformat} only closes {noformat}, and inside {code} only a bare {code} closes it.
Tests (IssueTextTests, for {noformat}, {code} and {code:none}): criteria headings, section lookup and panel layout ignore a quoted sample like MS-26773's, and a section containing the quote still returns it verbatim. The 12 new cases failed before the change. Full suite: 1011 run, 1011 passed.