Skip to content

fix: a negated exam question is not scored as created - #17

Merged
davidnmbond merged 1 commit into
mainfrom
fix/certification-negation
Nov 10, 2026
Merged

davidnmbond merged 1 commit into
mainfrom
fix/certification-negation

Conversation

@davidnmbond

Copy link
Copy Markdown
Contributor

Fixes #11.

The Certifications check's 'created' tier matched any mention of certification or exam, so MS-28010's 'No certification exam question is proposed for a single display column.' scored as 'Exam question(s) created'. Two tiers now run before it:

  • a negation (no [certification] [exam|assessment|test] question) followed by at least ten more characters on the line is a justified 'Not needed (reason given)', like the existing 'No certification question: ' tier;
  • a bare negation scores 'No exam question created' (0, with the usual recommendation).

A plain mention without negation is still 'created'.

NotNeededTierTests: the MS-28010 sentence, two bare negations, and a non-negated mention; the three negation cases failed before the change. Full suite, including Yoda parity: 1003 run, 1003 passed.

Fixes #11. 'No certification exam question is proposed ...' scores as not needed with a reason; a bare negation scores as no exam question created.
@codacy-production

codacy-production Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c13989) 2071 2068 99.86%
Head commit (34b60e3) 2071 (+0) 2068 (+0) 99.86% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit b349bd2 into main Nov 10, 2026
7 checks passed
@davidnmbond
davidnmbond deleted the fix/certification-negation branch November 10, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certifications check reports an exam question as created when the description says none is proposed

1 participant