Skip to content

Fix: pass stream error to next and call destroyAndRestore() in secondGuessSourceContentType error handling#206

Open
outlawtorn wants to merge 1 commit intopapandreou:masterfrom
outlawtorn:master
Open

Fix: pass stream error to next and call destroyAndRestore() in secondGuessSourceContentType error handling#206
outlawtorn wants to merge 1 commit intopapandreou:masterfrom
outlawtorn:master

Conversation

@outlawtorn
Copy link
Copy Markdown
Contributor

Summary

  • Fixed a bug in the secondGuessSourceContentType error path where next(500) was called instead of next(err), discarding the original stream error
  • Added destroyAndRestore() before next(err) to restore the hijacked response methods so the error handler can write a response to the client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant