chore(cli): Quality of lite improvement in preparation for paseo v2#148
Merged
Conversation
CI Summary
Release - PassedTest this PR Download artifact (GitHub CLI required): gh run download 26647606100 -n cli-release-0.0.0-pr.148 -R paritytech/dotns-sdkInstall globally: npm install -g ./parity-dotns-cli-0.0.0-pr.148.tgzVerify: dotns --helpDeploy UI — FailedFailed at: Deploy — Deploy workflow failed — see run logs for upload/register/contenthash details
Deploy Example — FailedFailed at: Deploy — Deploy workflow failed — see run logs for upload/register/contenthash details
Benchmark UI - Failed (0s)
Labelspkg: cli, scope: bulletin, type: test, dependencies, pkg: ui Test - Passed191 passed, 0 failed across 191 tests. |
| DOTNS_CONTENT_RESOLVER: "0x2c9FF5D9136DBE5814C7B4FDbeDC15273a776663" as Address, | ||
| STORE_FACTORY: "0x0DE5De70d61cc6b44B45d6595afDe8dB9b55bc31" as Address, | ||
| DOTNS_RULES: "0x2002C1c15b88632Ad01c7770f6EbE1Ca05c8472E" as Address, | ||
| DOTNS_REGISTRAR: "0x0000000000000000000000000000000000000000" as Address, |
Collaborator
There was a problem hiding this comment.
Reminder to update all of these before I merge
Collaborator
mordamax
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the
dotnsCLI up to date with the upcoming paseo-v2 contract release. The shipped CLI was diverging from the deployed contracts in small but real ways, and the new deposit lifecycle had no command surface at all. This PR closes both gaps.What changes for users:
dotns escrowgroup covering the full deposit lifecycle: check the status of a name's escrow position, release the name into escrow, withdraw after the cooldown, drain any overpayment held in the legacy pull ledger, and list, claim, or batch-claim entries from the new time-locked refund ledger. Before this PR none of these flows existed in the CLI; users had to interact with the escrow contract by hand.Tests have been added to lock the new behaviour: the trailing-digit rule, the new escrow help text and output formatting, a small JSON-output change that lets bigint fields serialise safely, and a live-chain integration test that walks through register, status, release, status. A few redundant assertions in the environment tests have been removed since they were each checking the same hardcoded deployment address; they had nothing to do with what the test was about, and the suite now makes no assumption about which addresses are deployed.
Type
Package
@parity/dotns-cliRelated Issues
n/a
Fixes
n/a
Checklist
Code
bun run lintpasses — let CI verifybun run formatpasses — let CI verifybun run typecheckpassesDocumentation
Breaking Changes
Breaking changes: n/a
Testing
How to test:
escrowis listed; then look atescrow --helpandescrow refunds --helpto see the new subcommands.Notes
The integration tests do not hardcode any contract address. They drive the CLI surface and let the bundled environment configuration resolve which addresses to use, so they continue to work whenever a fresh deployment is recorded. The decision to regenerate every ABI rather than patch only the escrow one was deliberate: piecemeal patching is how drift accumulated in the first place.