chore(cli): add retry logic to names and fix benchmarking suite#162
Open
sphamjoli wants to merge 1 commit into
Open
chore(cli): add retry logic to names and fix benchmarking suite#162sphamjoli wants to merge 1 commit into
sphamjoli wants to merge 1 commit into
Conversation
CI Summary
Release - PassedTest this PR Download artifact (GitHub CLI required): gh run download 26921516876 -n cli-release-0.0.0-pr.162 -R paritytech/dotns-sdkInstall globally: npm install -g ./parity-dotns-cli-0.0.0-pr.162.tgzVerify: dotns --helpDeploy UI — Passed
Deploy Example — Passed
Labelspkg: cli, type: docs, type: test, scope: benchmark Test - Passed229 passed, 0 failed across 229 tests. Waited for other CI summary workflows and hit the timeout; wrote the latest available summary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds resumable domain registration so an interrupted commit-reveal can be recovered instead of restarted. The reveal secret is cached locally and encrypted at rest with the caller's credential, and can be resumed, listed, or cleared. On failure, registration can automatically retry from the cached commitment, and this is wired through the deploy workflows. Also refactors the registration command to remove duplicated transfer, finalise, and banner logic, and caps benchmarks at 100MB.
Type
Package
@parity/dotns-cliRelated Issues
Fixes
Checklist
Code
bun run lintpassesbun run formatpassesbun run typecheckpassesDocumentation
Breaking Changes
Breaking changes:
None.
Testing
How to test:
Notes
Benchmarks now cover sizes up to 100MB only. The dated results snapshot is kept as a historical record and left unchanged.