Skip to content

chore(cli): add retry logic to names and fix benchmarking suite#162

Open
sphamjoli wants to merge 1 commit into
mainfrom
spha/commitment-retry
Open

chore(cli): add retry logic to names and fix benchmarking suite#162
sphamjoli wants to merge 1 commit into
mainfrom
spha/commitment-retry

Conversation

@sphamjoli
Copy link
Copy Markdown
Member

Description

Adds resumable domain registration so an interrupted commit-reveal can be recovered instead of restarted. The reveal secret is cached locally and encrypted at rest with the caller's credential, and can be resumed, listed, or cleared. On failure, registration can automatically retry from the cached commitment, and this is wired through the deploy workflows. Also refactors the registration command to remove duplicated transfer, finalise, and banner logic, and caps benchmarks at 100MB.

Type

  • Bug fix
  • Feature
  • Breaking change
  • Documentation
  • Chore

Package

  • @parity/dotns-cli
  • Root/monorepo
  • Documentation

Related Issues

Fixes

Checklist

Code

  • Follows project style
  • bun run lint passes
  • bun run format passes
  • bun run typecheck passes

Documentation

  • README updated if needed
  • Types updated if needed

Breaking Changes

  • No breaking changes
  • Breaking changes documented below

Breaking changes:

None.

Testing

How to test:

  1. Start a base registration, interrupt it during the commitment countdown, then run the retry command and confirm the name registers.
  2. Run the list and clear commands to review and purge cached commitments.
  3. Run the registration with a retry count and confirm it resumes from the cached commitment on failure.

Notes

Benchmarks now cover sizes up to 100MB only. The dated results snapshot is kept as a historical record and left unchanged.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

CI Summary

Check Result
Lint Passed
Format Passed
Typecheck Passed
Build Passed
Release Passed
Deploy UI Passed
Deploy Example Passed
PR Title Passed
Labels Passed
Test Passed - 229 passed, 0 failed

Release - Passed

Test this PR

Download artifact (GitHub CLI required):

gh run download 26921516876 -n cli-release-0.0.0-pr.162 -R paritytech/dotns-sdk

Install globally:

npm install -g ./parity-dotns-cli-0.0.0-pr.162.tgz

Verify:

dotns --help
Deploy UI — Passed
Stage Status
✓ Build Build succeeded
✓ Deploy Deployed
Property Value
Domain pr162.dotns.dot
CID bafybeih32eydm3mpipkgtgfpjlixmkzx7wedxk2j2lnumaena45n2kwnhu
URL (dot.li) https://dot.li/pr162.dotns.dot
URL (direct) https://pr162.dotns.dot

View run

Deploy Example — Passed
Stage Status
✓ Site validation Site validated
✓ Deploy Deployed
Property Value
Domain pr162.dotns-example-site.dot
CID bafybeicx555prsudvmqsdrap7keoilryrudwycdx3ody2rejwqwjwp52u4
URL (dot.li) https://dot.li/pr162.dotns-example-site.dot
URL (direct) https://pr162.dotns-example-site.dot
Duration 116s

View run

Labels

pkg: cli, type: docs, type: test, scope: benchmark

Test - Passed

229 passed, 0 failed across 229 tests.

Waited for other CI summary workflows and hit the timeout; wrote the latest available summary.

View run

$ bun test tests/unit/
bun test v1.2.6 (8ebd5d53)

::group::tests/unit/utils/formatting.test.ts:
(pass) native balance formatting uses DOT/PAS 10 decimals > defaults to 10 native decimals and 18 EVM decimals [1.00ms]
(pass) native balance formatting uses DOT/PAS 10 decimals > formatNativeBalance renders 5000 PAS from 5000 * 10^10 units [1.00ms]
(pass) native balance formatting uses DOT/PAS 10 decimals > formatNativeBalance renders fractional 0.1 PAS as 10^9 units
(pass) native balance formatting uses DOT/PAS 10 decimals > formatNativeBalance renders zero balance
(pass) native balance formatting uses DOT/PAS 10 decimals > parseNativeBalance inverts formatNativeBalance
(pass) native balance formatting uses DOT/PAS 10 decimals > parseNativeBalance('0.1') is 10^9
(pass) withTimeout cancels and cleans up the losing branch > resolves with the wrapped value when it settles first [1.00ms]
(pass) withTimeout cancels and cleans up the losing branch > rejects with a descriptive message when the timeout wins [10.00ms]
(pass) withTimeout cancels and cleans up the losing branch > invokes onTimeout exactly once when the timeout wins [10.00ms]
(pass) withTimeout cancels and cleans up the losing branch > does not invoke onTimeout when the wrapped promise settles first [255.00ms]

::endgroup::

::group::tests/unit/utils/contractInteractions.test.ts:
(pass) isRevertFlag matches the EVM revert bit > flags=0n → false
(pass) isRevertFlag matches the EVM revert bit > flags=1n → true
(pass) isRevertFlag matches the EVM revert bit > flags=2n → false
(pass) isRevertFlag matches the EVM revert bit > flags=3n → true
(pass) buildRevertError > empty data returns the unmapped-origin hint [1.00ms]
(pass) buildRevertError > known ABI selector decodes to the named error [5.00ms]
(pass) buildRevertError > unknown selector falls back to raw hex [1.00ms]

::endgroup::

::group::tests/unit/utils/validation.test.ts:
(pass) countTrailingDigits > returns 0 for a label with no trailing digits [1.00ms]
(pass) countTrailingDigits > returns the digit run length for a label with trailing digits
(pass) countTrailingDigits > does not count interior digits
(pass) stripTrailingDigits > returns the label unchanged when there are no trailing digits
(pass) stripTrailingDigits > strips the trailing digit run
(pass) validateDomainLabel digit-suffix rule > accepts labels with no trailing digits
(pass) validateDomainLabel digit-suffix rule > accepts labels with exactly two trailing digits
(pass) validateDomainLabel digit-suffix rule > rejects labels with exactly one trailing digit
(pass) validateDomainLabel digit-suffix rule > rejects labels with three or more trailing digits [1.00ms]
(pass) validateDomainLabel digit-suffix rule > rejects labels shorter than three characters [1.00ms]
(pass) validateDomainLabel digit-suffix rule > rejects labels with uppercase characters
(pass) validateDomainLabel digit-suffix rule > rejects labels with leading or trailing hyphen
(pass) validateGovernanceLabel stem-length rule > accepts stems of five characters or fewer
(pass) validateGovernanceLabel stem-length rule > rejects stems longer than five characters
(pass) validateGovernanceLabel stem-length rule > inherits the digit-suffix rule from validateDomainLabel

::endgroup::

::group::tests/unit/lookup/lookupHelp.test.ts:
(pass) lookup --help lists subcommands and auth options [13.00ms]
(pass) lookup name --help shows label argument and options [3.00ms]
(pass) lookup owner-of --help shows label argument and options [2.00ms]
(pass) lookup transfer --help shows label argument and destination option [2.00ms]
(pass) lookup transfer parses destination at transfer level [2.00ms]
(pass) lookup transfer parses auth options at lookup level [2.00ms]

::endgroup::

::group::tests/unit/account/accountHelp.test.ts:
(pass) account --help lists subcommands including is-mapped, is-whitelisted, whitelist [2.00ms]
(pass) account is-mapped --help shows address argument and --json [1.00ms]
(pass) account is-whitelisted --help shows address argument and --json [1.00ms]
(pass) account whitelist --help shows address argument, --remove, and --json [1.00ms]
(pass) account is alias works for is-mapped [1.00ms]
(pass) account iw alias works for is-whitelisted [2.00ms]

::endgroup::

::group::tests/unit/content/contentJson.test.ts:
(pass) content view --help shows --json option [1.00ms]
(pass) content set --help shows --json option [2.00ms]
(pass) content set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

::group::tests/unit/content/contentHelp.test.ts:
result:  {
  exitCode: 0,
  standardOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>         DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>     Alias for --env\n  --rpc <wsUrl>               WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>      Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --min-balance <pas>         Minimum balance in PAS (env:\n                              DOTNS_MIN_BALANCE_PAS)\n  --account <name>            Keystore account name (default: keystore default)\n  --password <pw>             Keystore password (env: DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>     BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>         Substrate key URI (env: DOTNS_KEY_URI)\n  -h, --help                  display help for command\n\nCommands:\n  view [options] <name>       View domain content hash\n  set [options] <name> <cid>  Set domain content hash (IPFS CID)\n  help [command]              display help for command\n",
  standardError: "",
  combinedOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>         DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>     Alias for --env\n  --rpc <wsUrl>               WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>      Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --min-balance <pas>         Minimum balance in PAS (env:\n                              DOTNS_MIN_BALANCE_PAS)\n  --account <name>            Keystore account name (default: keystore default)\n  --password <pw>             Keystore password (env: DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>     BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>         Substrate key URI (env: DOTNS_KEY_URI)\n  -h, --help                  display help for command\n\nCommands:\n  view [options] <name>       View domain content hash\n  set [options] <name> <cid>  Set domain content hash (IPFS CID)\n  help [command]              display help for command\n",
}
(pass) content --help lists subcommands and auth options [2.00ms]
(pass) content view --help shows name argument and options [2.00ms]
(pass) content set --help shows name and cid arguments [1.00ms]

::endgroup::

::group::tests/unit/cli/environment.test.ts:
(pass) defaults to paseo-v2 [1.00ms]
(pass) accepts friendly paseo-v2 aliases
(pass) DOTNS_ENV selects rpc and contract set
(pass) --env takes precedence over DOTNS_ENV while --rpc only overrides endpoint

::endgroup::

::group::tests/unit/cli/bulletinRpc.test.ts:
(pass) paseo-v2 default resolves to the existing bulletin RPC
(pass) explicit argument wins over env var and active env
(pass) env var wins over active env config when no explicit argument
(pass) falls back to active env's bulletin RPC
(pass) throws when nothing is configured (synthetic case)

::endgroup::

::group::tests/unit/cli/reporter.test.ts:
(pass) cli reporter > stream reporter emits durable progress lines
(pass) cli reporter > withConsoleToStderr redirects console and stdout writes [1.00ms]

::endgroup::

::group::tests/unit/text/textHelp.test.ts:
(pass) text --help lists subcommands and auth options [3.00ms]
(pass) text view --help shows name and key arguments [1.00ms]
(pass) text set --help shows name, key, and value arguments [2.00ms]

::endgroup::

::group::tests/unit/text/textJson.test.ts:
(pass) text view --help shows --json option [3.00ms]
(pass) text set --help shows --json option [1.00ms]
(pass) text set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

::group::tests/unit/store/storeHelp.test.ts:
(pass) store --help lists subcommands [2.00ms]
(pass) store claim --help shows description and auth options [1.00ms]
(pass) store info --help shows auth options [2.00ms]
(pass) store list --help shows options [1.00ms]
(pass) store get --help shows key argument [1.00ms]
(pass) store set --help shows key and value arguments with auth [1.00ms]
(pass) store delete --help shows key argument with auth [1.00ms]

::endgroup::

::group::tests/unit/bulletin/bulletinCliHelp.test.ts:
(pass) root help lists bulletin command [2.00ms]
(pass) bulletin help shows commands and description [2.00ms]
(pass) bulletin upload help shows all options [2.00ms]
(pass) bulletin upload help shows default values [2.00ms]
(pass) bulletin authorize help shows all options [2.00ms]
(pass) bulletin authorize help shows default values [1.00ms]
(pass) bulletin history help shows options [2.00ms]
(pass) bulletin history:remove help shows usage [1.00ms]
(pass) bulletin history:clear help shows description [1.00ms]
(pass) bulletin help command shows bulletin help [2.00ms]
(pass) bulletin help upload shows upload help [1.00ms]
(pass) bulletin help authorize shows authorize help [1.00ms]
(pass) bulletin status help shows all options [2.00ms]
(pass) bulletin help status shows status help [1.00ms]
(pass) bulletin list alias works [1.00ms]
(pass) bulletin verify help shows usage [1.00ms]
(pass) bulletin help verify shows verify help [2.00ms]

::endgroup::

::group::tests/unit/bulletin/bulletinAuthorizer.test.ts:
(pass) bulletin authorizer default > defaults to //Eve, the seeded AllowedAuthorizers account [1.00ms]
(pass) bulletin authorizer default > is distinct from the sudo key, which stays //Alice
(pass) warnIfDevKeyOnTestnet > warns when the default authorizer is used against previewnet
(pass) warnIfDevKeyOnTestnet > stays silent on paseo-v2 even with the default authorizer
(pass) warnIfDevKeyOnTestnet > stays silent when an explicit signer overrides the default

::endgroup::

::group::tests/unit/bulletin/bulletinHelpers.test.ts:
(pass) clampU32 > accepts zero
(pass) clampU32 > accepts U32_MAX
(pass) clampU32 > accepts number input
(pass) clampU32 > rejects negative bigint with field name in message
(pass) clampU32 > rejects negative number with field name in message
(pass) clampU32 > rejects values above U32_MAX
(pass) isAuthorizationSufficient > returns false when not authorised
(pass) isAuthorizationSufficient > returns false when authorised but expired
(pass) isAuthorizationSufficient > returns true when authorised and not expired
(pass) isAuthorizationSufficient > returns true when authorised and expired is undefined
(pass) isTestnetSpecName > classifies paseo as testnet=%s [1.00ms]
(pass) isTestnetSpecName > classifies paseo-asset-hub as testnet=%s
(pass) isTestnetSpecName > classifies westend as testnet=%s
(pass) isTestnetSpecName > classifies rococo as testnet=%s
(pass) isTestnetSpecName > classifies foo-testnet as testnet=%s
(pass) isTestnetSpecName > classifies bar-devnet as testnet=%s
(pass) isTestnetSpecName > classifies something-test as testnet=%s
(pass) isTestnetSpecName > classifies something-dev as testnet=%s
(pass) isTestnetSpecName > classifies PASEO as testnet=%s
(pass) isTestnetSpecName > classifies polkadot as testnet=%s
(pass) isTestnetSpecName > classifies kusama as testnet=%s
(pass) isTestnetSpecName > classifies asset-hub-polkadot as testnet=%s
(pass) isTestnetSpecName > classifies  as testnet=%s
(pass) isTestnetSpecName > returns false for null and undefined

::endgroup::

::group::tests/unit/bulletin/uploadProfiling.test.ts:
(pass) upload profiler > writes schema-complete profile report with peak aggregation [10.00ms]
(pass) upload profiler > default profile path is deterministic for a given fingerprint

::endgroup::

::group::tests/unit/bulletin/uploadManifest.test.ts:
(pass) upload manifest resume behavior > returns stale manifest when fingerprint does not match [2.00ms]
(pass) upload manifest resume behavior > deduplicates completed blocks by index

::endgroup::

::group::tests/unit/escrow/escrowHelp.test.ts:
(pass) root help lists escrow command [2.00ms]
(pass) escrow help shows the subcommand description and subcommands [1.00ms]
(pass) escrow status help describes the read-only position lookup [1.00ms]
(pass) escrow release help describes the approve-and-release sequence [1.00ms]
(pass) escrow withdraw help describes the post-cooldown step [1.00ms]
(pass) escrow claim-withdrawal help describes the overpayment ledger [1.00ms]
(pass) escrow refunds help lists list/claim/claim-batch [1.00ms]
(pass) escrow refunds list help exposes pagination options [1.00ms]
(pass) escrow refunds claim help requires an entry id positional [1.00ms]
(pass) escrow refunds claim-batch help accepts variadic ids [1.00ms]

::endgroup::

::group::tests/unit/escrow/escrowFormatting.test.ts:
(pass) formatRefundEntryLine > marks entries past their cooldown as claimable [1.00ms]
(pass) formatRefundEntryLine > marks entries inside their cooldown window with remaining seconds
(pass) formatRefundEntryLine > renders the amount as a PAS decimal string
(pass) formatRefundEntryLine > truncates large tokenIds for terminal display

::endgroup::

::group::tests/unit/auth/authHelp.test.ts:
(pass) root help lists auth command [1.00ms]
(pass) auth help shows options and subcommands [1.00ms]
(pass) auth set help shows all options [1.00ms]
(pass) auth list help shows options [1.00ms]
(pass) auth use help shows options [2.00ms]
(pass) auth remove help shows options [1.00ms]
(pass) auth clear help shows options [1.00ms]
(pass) auth parses keystore-path option [2.00ms]
(pass) auth parses password option [1.00ms]
(pass) auth set parses account option [1.00ms]
(pass) auth set parses mnemonic option [1.00ms]
(pass) auth set parses key-uri option [1.00ms]
(pass) auth help command shows help [1.00ms]
(pass) auth help set shows set command help [2.00ms]
(pass) auth help list shows list command help [1.00ms]
(pass) auth help use shows use command help [2.00ms]
(pass) auth help remove shows remove command help
(pass) auth help clear shows clear command help [2.00ms]

::endgroup::

::group::tests/unit/auth/auth.test.ts:
(pass) auth set creates keystore and stores multiple accounts [232.00ms]
(pass) auth set accepts account names with special characters [353.00ms]
(pass) auth list reports missing keystore [4.00ms]
(pass) auth list shows all accounts and auth types [237.00ms]
(pass) auth use switches default account [338.00ms]
(pass) auth remove last account clears default [73.00ms]
(pass) auth remove preserves remaining accounts and reassigns default [166.00ms]
(pass) auth clear deletes all accounts [74.00ms]

::endgroup::

::group::tests/unit/auth/resolveAuthSourceReadOnly.test.ts:
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label

::endgroup::

::group::tests/unit/auth/authRevert.test.ts:
(pass) auth set rejects account name with forward slash [1.00ms]
(pass) auth set rejects account name with backslash [1.00ms]
(pass) auth set rejects account name that is just a dot [1.00ms]
(pass) auth set rejects account name that is double dots [1.00ms]
(pass) auth set rejects account name starting with dot [1.00ms]
(pass) auth set rejects account name ending with dot [2.00ms]
(pass) auth set rejects account name with special characters [9.00ms]
(pass) auth set rejects account name that is too long [1.00ms]
(pass) auth use rejects non-existent account [56.00ms]
(pass) auth remove rejects non-existent account [64.00ms]

::endgroup::

::group::tests/unit/register/registerJson.test.ts:
(pass) register domain --help shows --json option [1.00ms]
(pass) register subname --help shows --json option [2.00ms]
(pass) register domain --json emits JSON error when --transfer without --to [1.00ms]

::endgroup::

::group::tests/unit/register/registerOwnerConflicts.test.ts:
(pass) register domain rejects --owner with --transfer [3.00ms]
(pass) register domain rejects --owner with --reverse [1.00ms]
(pass) register domain rejects --owner with --governance [1.00ms]

::endgroup::

::group::tests/unit/register/registerHelp.test.ts:
(pass) root help lists register command [1.00ms]
(pass) register help shows subcommands [1.00ms]
(pass) register domain help shows options [1.00ms]
(pass) register subname help shows options [1.00ms]
(pass) register domain parses reverse flag [1.00ms]
(pass) register domain parses governance flag [1.00ms]
(pass) register domain parses owner option [1.00ms]
(pass) register domain parses transfer with destination [1.00ms]
(pass) register domain parses account option [1.00ms]
(pass) register domain parses keystore-path option [1.00ms]
(pass) register domain parses password option [1.00ms]
(pass) register domain parses mnemonic option [1.00ms]
(pass) register domain parses key-uri option [1.00ms]
(pass) register domain parses commitment-buffer option [1.00ms]
(pass) register domain parses commitment-buffer alias --cb [2.00ms]
(pass) register subname parses name and parent [2.00ms]
(pass) register subname parses owner option [1.00ms]
(pass) getCommitmentBufferSeconds defaults to 6 when env is not set
(pass) getCommitmentBufferSeconds reads from DOTNS_COMMITMENT_BUFFER env variable
(pass) COMMITMENT_POLL_INTERVAL_MS is 2000
(pass) COMMITMENT_POLL_TIMEOUT_MS is 30000 [1.00ms]

::endgroup::

::group::tests/unit/register/registrationManifest.test.ts:
(pass) registration manifest persistence > saves a record and reads it back by label [67.01ms]
(pass) registration manifest persistence > encrypts the secret at rest (never stored in plaintext) [51.01ms]
(pass) registration manifest persistence > decrypts the secret with the correct credential [106.02ms]
(pass) registration manifest persistence > rejects decryption with the wrong credential [116.02ms]
(pass) registration manifest persistence > lists records for the env + caller, newest commit first [105.02ms]
(pass) registration manifest persistence > isolates records by env and caller [117.02ms]
(pass) registration manifest persistence > deletes a record [51.01ms]
(pass) registration manifest persistence > returns empty when nothing is cached
(pass) resolveManifestCredential > prefers password, then mnemonic, then key URI
(pass) resolveManifestCredential > returns null when no credential is available

::endgroup::

::group::tests/unit/pop/setPopHelp.test.ts:
(pass) root help lists pop command [2.00ms]
(pass) pop help shows commands and description [2.00ms]
(pass) pop help shows auth options [1.00ms]
(pass) pop info help shows description [1.00ms]
(pass) pop status help shows description [2.00ms]
(pass) pop info help shows auth options [1.00ms]
(pass) pop info parses auth options at pop level [1.00ms]
(pass) pop info parses auth options at info level [1.00ms]
(pass) pop help command shows pop help [1.00ms]
(pass) pop help status shows info help [2.00ms]
(pass) pop help info shows info help [1.00ms]

::endgroup::

::group::tests/unit/pop/popJson.test.ts:
(pass) pop info --help shows --json option [2.00ms]
(pass) pop status --help shows --json option [1.00ms]

::endgroup::

 229 pass
 0 fail
 677 expect() calls
Ran 229 tests across 30 files. [3.01s]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant