Skip to content

bitswap_unstable: stream added#186

Merged
michalkucharczyk merged 11 commits into
mainfrom
mku-bitswap-stream
Jun 4, 2026
Merged

bitswap_unstable: stream added#186
michalkucharczyk merged 11 commits into
mainfrom
mku-bitswap-stream

Conversation

@michalkucharczyk
Copy link
Copy Markdown
Contributor

@michalkucharczyk michalkucharczyk commented May 7, 2026 •
edited
Loading

This PR adds: bitswap_unstable_stream

...and renames bitswap_v1_get to bitswap_unstable_get

@michalkucharczyk michalkucharczyk mentioned this pull request May 8, 2026
Draft
bkontur
bkontur reviewed May 8, 2026
View reviewed changes
Comment thread src/api/bitswap_v1_getMany.md Outdated
bkontur
bkontur reviewed May 8, 2026
View reviewed changes
Comment thread src/api/bitswap_v1_getMany.md Outdated
michalkucharczyk and others added 2 commits May 11, 2026 10:18
@michalkucharczyk @bkontur
Update src/api/bitswap_v1_getMany.md
7f2ae7c 
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
@michalkucharczyk
formatting
d877ba2
lexnv
lexnv reviewed May 11, 2026
View reviewed changes
Comment thread src/api/bitswap.md Outdated
lexnv
lexnv reviewed May 11, 2026
View reviewed changes
Comment thread src/api/bitswap_v1_stream.md Outdated
lexnv
lexnv reviewed May 11, 2026
View reviewed changes
Comment thread src/api/bitswap.md Outdated
skunert
skunert reviewed May 11, 2026
View reviewed changes
Comment thread src/api/bitswap.md Outdated
Comment thread src/api/bitswap_v1_getMany.md Outdated
Comment thread src/api/bitswap_v1_stream.md Outdated
Comment thread src/api/bitswap_v1_getMany.md Outdated
Comment thread src/api/bitswap.md Outdated
@skunert skunert mentioned this pull request May 12, 2026
Open
@michalkucharczyk michalkucharczyk changed the title bitswap_v1: stream and getMany added bitswap_unstable: stream added May 14, 2026
lexnv
lexnv previously approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michalkucharczyk michalkucharczyk mentioned this pull request May 19, 2026
Open
dmitry-markin
dmitry-markin approved these changes May 22, 2026
View reviewed changes
Comment thread src/api/bitswap.md Outdated
Comment thread src/api/bitswap_unstable_get.md
dmitry-markin
dmitry-markin previously approved these changes May 22, 2026
View reviewed changes
Comment thread src/api/bitswap_unstable_get.md Outdated
@lexnv lexnv mentioned this pull request May 22, 2026
Merged
@michalkucharczyk @dmitry-markin
Update src/api/bitswap_unstable_get.md
7b4f954 
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
@michalkucharczyk michalkucharczyk dismissed stale reviews from dmitry-markin and lexnv via 7b4f954 May 25, 2026 10:00
@dmitry-markin
Copy link
Copy Markdown
Contributor

dmitry-markin commented May 25, 2026

Actually, I don't think we should remove bitswap_v1_get. Polkadot app is likely already using it.

Introducing bitswap_unstable_get also can be postponed until we have to break bitswap_v1_get.

@michalkucharczyk @dmitry-markin
Update src/api/bitswap.md
45dd7e5 
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
@michalkucharczyk
Copy link
Copy Markdown
Contributor Author

michalkucharczyk commented May 25, 2026 •
edited
Loading

Actually, I don't think we should remove bitswap_v1_get. Polkadot app is likely already using it.

Introducing bitswap_unstable_get also can be postponed until we have to break bitswap_v1_get.

Alias will be kept - so bitswap_v1_get method will be working.
I also discussed it with @bkontur - app shall be updated, we still should have time to do it.

@lexnv
Copy link
Copy Markdown
Contributor

lexnv commented May 25, 2026

Alias will be kept - so bitswap_v1_get method will be working.
I also discussed it with @bkontur - app shall be updated, we still should have time to do it.

Perfect, ideally once we are sure the RPC method is stable (ie, no further modifications like changing / removing / adding hashig types and battle tested to gain feedback), we can turn this into a stable_v1 🙏

lexnv
lexnv approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for tackling the event formats for the steam implementation 🙏

@michalkucharczyk michalkucharczyk merged commit 479c649 into main Jun 4, 2026
5 checks passed
@michalkucharczyk michalkucharczyk deleted the mku-bitswap-stream branch June 4, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitry-markin dmitry-markin dmitry-markin approved these changes

@lexnv lexnv lexnv approved these changes

@bkontur bkontur Awaiting requested review from bkontur

@skunert skunert Awaiting requested review from skunert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michalkucharczyk @dmitry-markin @lexnv @skunert @bkontur