Community-code notice on pg mod + moddable prompt defaults to yes#272
Merged
Conversation
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small UX changes:
playground modcommunity-code notice. A light warning-tone callout now appears before any app source touches the user's machine:playground mod <domain>path (which skips the picker but still downloads and runs the app'ssetup.sh)The copy follows the marketplace-standard register (community-published, not reviewed, use at your own risk) and is deliberately specific about the real exposure point: modding runs the app's setup script locally. It is a notice, not a gate;
setup.shstill runs automatically.The copy lives in one module (
src/commands/mod/communityNotice.ts) so both screens stay identical. The picker's viewport math reserves rows for the box so tall lists don't overflow the terminal.playground deploymoddable prompt defaults to yes. The cursor on "make this app moddable?" now starts on "yes", so plain Enter opts in. First slice of the moddable-by-default work (Moddable-by-default deploy + guided GitHub login & repo creation flow #200); the graceful handling of a missing GitHub origin is a follow-up.Verification
pnpm format:check,pnpm lint:license,pnpm build,pnpm test(579 tests) all passChangeset included.