fix(tui): title-case callout titles, add phone-ready notice on deploy start#279
Merged
UtkarshBhardwaj007 merged 1 commit intoJun 4, 2026
Merged
Conversation
… start
All bordered callout titles now use Title Case ("Moddable Setup Needed",
"Check Your Phone", "README Will Not Be Uploaded", etc.) while section
titles, row labels, and hints keep the deliberate lowercase aesthetic.
Phone-signed deploys now show a "Keep Your Phone Ready" callout the
moment the run starts, so users have the mobile app ready before the
first approval prompt. The notice clears when the first sign-request
arrives (the per-step approval callout takes over) and on finish/error,
since RunningStage stays mounted through the done and error stages.
Dev-mode deploys never show it.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Callouttitles changed.Behaviour notes
phone. Dev-mode deploys (which can still need 0-1 taps) intentionally don't show it; the existing per-step "Check Your Phone" callout still covers any actual tap.RunningStagestays mounted through thedone/errorstages.setShowPhoneNotice(false)on later sign-requests is a deliberate no-op: React bails out of re-rendering on same-value state sets, so don't "optimize" it into a guard.Verification
pnpm format:checkcleanpnpm lint:licenseclean (198 files)pnpm test643/643 passedtsc --noEmiterror count unchanged at the 13-error baseline