Skip to content

fix(tui): title-case callout titles, add phone-ready notice on deploy start#279

Merged
UtkarshBhardwaj007 merged 1 commit into
mainfrom
fix/callout-title-case-phone-ready-notice
Jun 4, 2026
Merged

fix(tui): title-case callout titles, add phone-ready notice on deploy start#279
UtkarshBhardwaj007 merged 1 commit into
mainfrom
fix/callout-title-case-phone-ready-notice

Conversation

@UtkarshBhardwaj007
Copy link
Copy Markdown
Member

What

  • All bordered callout titles now use Title Case: "Moddable Setup Needed", "Check Your Phone", "README Will Not Be Uploaded", "About This Command", "Owned by a Development Account", "Signing Failed", "Decentralize Failed". Section titles, row labels, and hints keep the deliberate lowercase aesthetic; only bordered Callout titles changed.
  • Phone-signed deploys show a "Keep Your Phone Ready" callout the moment Enter is pressed on the confirm screen, so users have the mobile app ready before the first approval prompt:
╭──────────────────────────────────────────────────────────╮
│ Keep Your Phone Ready                                    │
│ This deploy will ask you to approve transactions in your │
│ mobile app.                                              │
╰──────────────────────────────────────────────────────────╯

Behaviour notes

  • The notice renders only when the resolved signer mode is phone. Dev-mode deploys (which can still need 0-1 taps) intentionally don't show it; the existing per-step "Check Your Phone" callout still covers any actual tap.
  • It clears when the first sign-request arrives (the per-step approval callout takes over) and on finish/error, since RunningStage stays mounted through the done/error stages.
  • The repeated setShowPhoneNotice(false) on later sign-requests is a deliberate no-op: React bails out of re-rendering on same-value state sets, so don't "optimize" it into a guard.

Verification

  • pnpm format:check clean
  • pnpm lint:license clean (198 files)
  • pnpm test 643/643 passed
  • tsc --noEmit error count unchanged at the 13-error baseline
  • Changeset included (patch)

… start

All bordered callout titles now use Title Case ("Moddable Setup Needed",
"Check Your Phone", "README Will Not Be Uploaded", etc.) while section
titles, row labels, and hints keep the deliberate lowercase aesthetic.

Phone-signed deploys now show a "Keep Your Phone Ready" callout the
moment the run starts, so users have the mobile app ready before the
first approval prompt. The notice clears when the first sign-request
arrives (the per-step approval callout takes over) and on finish/error,
since RunningStage stays mounted through the done and error stages.
Dev-mode deploys never show it.
@UtkarshBhardwaj007 UtkarshBhardwaj007 merged commit 221a66f into main Jun 4, 2026
19 checks passed
@UtkarshBhardwaj007 UtkarshBhardwaj007 deleted the fix/callout-title-case-phone-ready-notice branch June 4, 2026 17:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Dev build ready — try this branch:

curl -fsSL https://raw.githubusercontent.com/paritytech/playground-cli/main/install.sh | VERSION=dev/fix/callout-title-case-phone-ready-notice bash

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

E2E Test Pass · ✅ PASS

Tag: e2e-ci-pr · Branch: fix/callout-title-case-phone-ready-notice · Commit: 488aef7 · Run logs

Cell Result Time
pr-install ✅ PASS 0m51s
pr-init-session ✅ PASS 1m50s
pr-deploy-foundry ✅ PASS 0m43s
pr-preflight ✅ PASS 2m18s
pr-deploy-cdm ✅ PASS 4m10s
pr-mod ✅ PASS 1m27s
pr-deploy-frontend ✅ PASS 8m12s
${{ matrix.cell }} ⏭️ SKIP 0m00s
${{ matrix.cell }} ⏭️ SKIP 0m00s

Sentry traces: view spans for this run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant