Conversation
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
kvpanch
approved these changes
May 26, 2026
Contributor
kvpanch
left a comment
kvpanch
left a comment
There was a problem hiding this comment.
maybe we need to add fuzzer similar to PVM ?
Member
Author
Yes we do. Its on the back of my mind since a long while. This is also the reason why I the LLVM builder supports building with coverage. |
xermicus
changed the title
elle-j
approved these changes
May 26, 2026
Contributor
elle-j
left a comment
elle-j
left a comment
There was a problem hiding this comment.
LGTM, could you add a CHANGELOG entry briefly describing this fix?
|
|
||
| /// Surfaces the `smod(INT_MIN, -1)` LLVM-UB const-fold bug from | ||
| /// paritytech/revive#524. See `SmodIntMinNegOneBug.yul` for why this specific | ||
| /// fixture is shaped the way it is. Expected to FAIL until the bug is fixed. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// fixture is shaped the way it is. Expected to FAIL until the bug is fixed. | |
| /// fixture is shaped the way it is. |
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing test coverage didn't catch a signed remainder overflow semantics edge case behavior where at least one the operators is being constant folded by LLVM instead of solc. This PR fixes the SREM translation bug and adds missing test coverage for division ops with constants.
Closes #524